Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instances add ipv6 attribute #29794

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

NabilHouidi
Copy link
Contributor

@NabilHouidi NabilHouidi commented Mar 5, 2023

Description

Adds ipv6 addresses to aws-instances data source.

Tests gad to be updates because the default vpc does not have ipv6 enabled out of the box

Relations

Closes #29708

References

Output from Acceptance Testing

make testacc TESTS=TestAccEC2InstancesDataSource_basic PKG=ec2                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_basic'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== CONT  TestAccEC2InstancesDataSource_basic
--- PASS: TestAccEC2InstancesDataSource_basic (117.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	117.578s

make testacc TESTS=TestAccEC2InstancesDataSource_timeout PKG=ec2              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_timeout'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_timeout
=== PAUSE TestAccEC2InstancesDataSource_timeout
=== CONT  TestAccEC2InstancesDataSource_timeout
--- PASS: TestAccEC2InstancesDataSource_timeout (128.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	128.386s

make testacc TESTS=TestAccEC2InstancesDataSource_empty PKG=ec2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_empty'  -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== CONT  TestAccEC2InstancesDataSource_empty
--- PASS: TestAccEC2InstancesDataSource_empty (30.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	30.848s

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Mar 5, 2023
@NabilHouidi NabilHouidi force-pushed the f-ec2-aws-instances-add-ipv6 branch from 3829b0c to 207d67c Compare March 5, 2023 16:29
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@NabilHouidi NabilHouidi force-pushed the f-ec2-aws-instances-add-ipv6 branch from 207d67c to 1e0294f Compare March 8, 2023 20:12
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 9, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2InstancesDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2InstancesDataSource_ -timeout 180m
=== RUN   TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== RUN   TestAccEC2InstancesDataSource_tags
=== PAUSE TestAccEC2InstancesDataSource_tags
=== RUN   TestAccEC2InstancesDataSource_instanceStateNames
=== PAUSE TestAccEC2InstancesDataSource_instanceStateNames
=== RUN   TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== RUN   TestAccEC2InstancesDataSource_timeout
=== PAUSE TestAccEC2InstancesDataSource_timeout
=== CONT  TestAccEC2InstancesDataSource_basic
=== CONT  TestAccEC2InstancesDataSource_empty
=== CONT  TestAccEC2InstancesDataSource_timeout
--- PASS: TestAccEC2InstancesDataSource_empty (14.09s)
=== CONT  TestAccEC2InstancesDataSource_instanceStateNames
--- PASS: TestAccEC2InstancesDataSource_timeout (110.85s)
=== CONT  TestAccEC2InstancesDataSource_tags
--- PASS: TestAccEC2InstancesDataSource_basic (114.19s)
--- PASS: TestAccEC2InstancesDataSource_instanceStateNames (108.73s)
--- PASS: TestAccEC2InstancesDataSource_tags (119.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	236.020s

@ewbankkit
Copy link
Contributor

@NabilHouidi Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b4a4f53 into hashicorp:main Mar 9, 2023
@github-actions github-actions bot added this to the v4.58.0 milestone Mar 9, 2023
@github-actions
Copy link

This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sylr
Copy link
Contributor

sylr commented Mar 10, 2023

Thank you @NabilHouidi!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_instances IPv6 attribute
4 participants