-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instances add ipv6 attribute #29794
instances add ipv6 attribute #29794
Conversation
Community NoteVoting for Prioritization
For Submitters
|
3829b0c
to
207d67c
Compare
207d67c
to
1e0294f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2InstancesDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2InstancesDataSource_ -timeout 180m
=== RUN TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== RUN TestAccEC2InstancesDataSource_tags
=== PAUSE TestAccEC2InstancesDataSource_tags
=== RUN TestAccEC2InstancesDataSource_instanceStateNames
=== PAUSE TestAccEC2InstancesDataSource_instanceStateNames
=== RUN TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== RUN TestAccEC2InstancesDataSource_timeout
=== PAUSE TestAccEC2InstancesDataSource_timeout
=== CONT TestAccEC2InstancesDataSource_basic
=== CONT TestAccEC2InstancesDataSource_empty
=== CONT TestAccEC2InstancesDataSource_timeout
--- PASS: TestAccEC2InstancesDataSource_empty (14.09s)
=== CONT TestAccEC2InstancesDataSource_instanceStateNames
--- PASS: TestAccEC2InstancesDataSource_timeout (110.85s)
=== CONT TestAccEC2InstancesDataSource_tags
--- PASS: TestAccEC2InstancesDataSource_basic (114.19s)
--- PASS: TestAccEC2InstancesDataSource_instanceStateNames (108.73s)
--- PASS: TestAccEC2InstancesDataSource_tags (119.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 236.020s
@NabilHouidi Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Thank you @NabilHouidi! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds ipv6 addresses to
aws-instances
data source.Tests gad to be updates because the default vpc does not have ipv6 enabled out of the box
Relations
Closes #29708
References
Output from Acceptance Testing