-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casting of bitrate and sample rate for aac settings #29807
Fix casting of bitrate and sample rate for aac settings #29807
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @LasseEmilHildebrandt 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
We are aware of this, we are unable to change this at the current moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @LasseEmilHildebrandt 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
d66acac
to
7757ffe
Compare
@LasseEmilHildebrandt thanks for the contribution! Overall the PR looks good. Before I run test, can you merge/rebase this PR with main? A few dependencies have been added since last week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTS=TestAccMediaLiveChannel_ PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_' -timeout 180m
--- PASS: TestAccMediaLiveChannel_m2ts_settings (75.27s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (78.34s)
--- PASS: TestAccMediaLiveChannel_audioDescriptions_codecSettings (86.81s)
--- PASS: TestAccMediaLiveChannel_basic (90.10s)
--- PASS: TestAccMediaLiveChannel_updateTags (109.33s)
--- PASS: TestAccMediaLiveChannel_hls (146.02s)
--- PASS: TestAccMediaLiveChannel_disappears (153.50s)
--- PASS: TestAccMediaLiveChannel_update (216.78s)
--- PASS: TestAccMediaLiveChannel_status (261.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 264.870s
@LasseEmilHildebrandt thank you for the contribution! 🎉 |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixed castings for bitrate and sample_rate for aac_settings.
Relations
References
Output from Acceptance Testing