-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_amplify_domain_association: add enable_auto_sub_domain attribute #29814
r/aws_amplify_domain_association: add enable_auto_sub_domain attribute #29814
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thanks @megubyte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AMPLIFY_DOMAIN_NAME=example.com make testacc TESTARGS='-run=TestAccAmplify_serial/DomainAssociation' PKG=amplify
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 20 -run=TestAccAmplify_serial/DomainAssociation -timeout 180m
=== RUN TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT TestAccAmplify_serial
=== RUN TestAccAmplify_serial/DomainAssociation
=== RUN TestAccAmplify_serial/DomainAssociation/basic
=== RUN TestAccAmplify_serial/DomainAssociation/disappears
=== RUN TestAccAmplify_serial/DomainAssociation/update
--- PASS: TestAccAmplify_serial (215.94s)
--- PASS: TestAccAmplify_serial/DomainAssociation (215.94s)
--- PASS: TestAccAmplify_serial/DomainAssociation/basic (67.18s)
--- PASS: TestAccAmplify_serial/DomainAssociation/disappears (35.07s)
--- PASS: TestAccAmplify_serial/DomainAssociation/update (113.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amplify 220.904s
@megubyte Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a new
enable_auto_sub_domain
attribute which matches the API and the rest of the schema (schema usessub_domain
already), which was something requested in the issue linked below. Added support for updating, as well as reading this value back from the API.Relations
Closes #20495
References
N/A
Output from Acceptance Testing
Couldn't run the acceptance tests in the end - something seemed to stop me from running them (not related to my changes I think).