Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase aws_dms_replication_instance creation timeout #29905

Merged

Conversation

pedroarthur
Copy link
Contributor

Description

I've been setting up DMS replication instances for the past two weeks, and most terraform apply fail because of the creation timeout. However, the AWS DMS console shows that the instances are still creating. And, almost 2 to 3 minutes later, the console shows the instances as Available. Therefore, this seems the case to increase the instance creation timeout.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. labels Mar 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @pedroarthur 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 14, 2023
@johnsonaj johnsonaj self-assigned this Apr 14, 2023
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Apr 14, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccDMSReplicationInstance_basic' PKG=dms

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationInstance_basic -timeout 180m
=== RUN   TestAccDMSReplicationInstance_basic
=== PAUSE TestAccDMSReplicationInstance_basic
=== CONT  TestAccDMSReplicationInstance_basic
--- PASS: TestAccDMSReplicationInstance_basic (858.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	861.448s

@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 14, 2023
@johnsonaj
Copy link
Contributor

@pedroarthur thanks for the contribution! 🎉

@johnsonaj johnsonaj merged commit 29f114a into hashicorp:main Apr 14, 2023
@github-actions github-actions bot added this to the v4.64.0 milestone Apr 14, 2023
alewando pushed a commit to alewando/terraform-provider-aws that referenced this pull request Apr 14, 2023
* Increase aws_dms_replication_instance creation timeout

* add CHANGELOG entry

* update documentation

---------

Co-authored-by: Adrian Johnson <adrian.johnson@hashicorp.com>
@github-actions
Copy link

This functionality has been released in v4.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants