Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_fms_policy - add description #29926

Merged
merged 8 commits into from
Mar 13, 2023

Conversation

bennylu2
Copy link
Contributor

@bennylu2 bennylu2 commented Mar 12, 2023

Description

Add description to policy

Relations

Closes #29873

References

https://docs.aws.amazon.com/fms/2018-01-01/APIReference/API_Policy.html

Note: I was unable to run tests, it requires management account

=== RUN   TestAccFMS_serial/Policy/basic
    acctest.go:914: this AWS account must be the management account of an AWS Organization

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Mar 12, 2023
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 12, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 13, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccFMS_serial/Policy/basic' PKG=fms 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fms/... -v -count 1 -parallel 20  -run=TestAccFMS_serial/Policy/basic -timeout 180m
=== RUN   TestAccFMS_serial
=== PAUSE TestAccFMS_serial
=== CONT  TestAccFMS_serial
=== RUN   TestAccFMS_serial/Policy
=== RUN   TestAccFMS_serial/Policy/basic
--- PASS: TestAccFMS_serial (1231.16s)
    --- PASS: TestAccFMS_serial/Policy (1231.16s)
        --- PASS: TestAccFMS_serial/Policy/basic (1231.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	1236.498s

@github-actions github-actions bot added service/wafregional Issues and PRs that pertain to the wafregional service. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Mar 13, 2023
@ewbankkit
Copy link
Contributor

@bennylu2 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6364bc4 into hashicorp:main Mar 13, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 13, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/fms Issues and PRs that pertain to the fms service. service/wafregional Issues and PRs that pertain to the wafregional service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Firewall Manager does not have Description
3 participants