Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_lightsail_distribution #30124

Merged
merged 28 commits into from
Mar 31, 2023

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Mar 19, 2023

Description

This pull request adds the new aws_lightsail_distribution resource and allows managing lightsail distributions with terraform.

Relations

Closes #30011

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccLightsailDistribution_serial' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDistribution_serial -timeout 180m
=== RUN   TestAccLightsailDistribution_serial
=== PAUSE TestAccLightsailDistribution_serial
=== CONT  TestAccLightsailDistribution_serial
=== RUN   TestAccLightsailDistribution_serial/distribution
=== RUN   TestAccLightsailDistribution_serial/distribution/default_cache_behavior
=== RUN   TestAccLightsailDistribution_serial/distribution/ip_address_type
=== RUN   TestAccLightsailDistribution_serial/distribution/tags
=== RUN   TestAccLightsailDistribution_serial/distribution/basic
=== RUN   TestAccLightsailDistribution_serial/distribution/disappears
=== RUN   TestAccLightsailDistribution_serial/distribution/is_enabled
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior_settings
--- PASS: TestAccLightsailDistribution_serial (4679.95s)
    --- PASS: TestAccLightsailDistribution_serial/distribution (4679.95s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (697.36s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (657.13s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/tags (360.77s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/basic (342.20s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/disappears (338.98s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (968.10s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (663.07s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (652.33s)
PASS
ok    github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  4686.523s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Mar 19, 2023
@brittandeyoung brittandeyoung added the new-resource Introduces a new resource. label Mar 22, 2023
@brittandeyoung brittandeyoung changed the title [WIP] New Resource: aws_lightsail_distribution New Resource: aws_lightsail_distribution Mar 23, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 31, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccLightsailDistribution_serial' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDistribution_serial -timeout 180m
=== RUN   TestAccLightsailDistribution_serial
=== PAUSE TestAccLightsailDistribution_serial
=== CONT  TestAccLightsailDistribution_serial
=== RUN   TestAccLightsailDistribution_serial/distribution
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior_settings
=== RUN   TestAccLightsailDistribution_serial/distribution/default_cache_behavior
=== RUN   TestAccLightsailDistribution_serial/distribution/ip_address_type
=== RUN   TestAccLightsailDistribution_serial/distribution/tags
=== RUN   TestAccLightsailDistribution_serial/distribution/basic
=== RUN   TestAccLightsailDistribution_serial/distribution/disappears
=== RUN   TestAccLightsailDistribution_serial/distribution/is_enabled
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior
--- PASS: TestAccLightsailDistribution_serial (4712.13s)
    --- PASS: TestAccLightsailDistribution_serial/distribution (4712.13s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (711.63s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (687.45s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (653.38s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/tags (359.86s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/basic (341.78s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/disappears (340.97s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (964.03s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (653.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	4717.345s

@ewbankkit ewbankkit merged commit d7b8dec into hashicorp:main Mar 31, 2023
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]:
2 participants