Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding certificate_data_source to dms #30498

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Adding certificate_data_source to dms #30498

merged 1 commit into from
Apr 7, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Apr 6, 2023 •
edited
Loading

Description

This PR adds certificate_data_source to the dms resource.

Relations

Relates #12713

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccDMSCertificateDataSource_basic' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSCertificateDataSource_basic -timeout 180m
=== RUN   TestAccDMSCertificateDataSource_basic
=== PAUSE TestAccDMSCertificateDataSource_basic
=== CONT  TestAccDMSCertificateDataSource_basic
--- PASS: TestAccDMSCertificateDataSource_basic (11.85s)
PASS

...

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 6, 2023
@nam054 nam054 force-pushed the f-dms-certificate-ds branch 2 times, most recently from 0deddab to 2ccc096 Compare April 7, 2023 17:03
@nam054 nam054 marked this pull request as ready for review April 7, 2023 17:23
jar-b
jar-b approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccDMSCertificateDataSource_basic' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSCertificateDataSource_basic -timeout 180m
=== RUN   TestAccDMSCertificateDataSource_basic
=== PAUSE TestAccDMSCertificateDataSource_basic
=== CONT  TestAccDMSCertificateDataSource_basic
--- PASS: TestAccDMSCertificateDataSource_basic (14.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        17.648s

internal/service/dms/certificate_data_source_test.go Outdated Show resolved Hide resolved
internal/service/dms/certificate_data_source.go Outdated Show resolved Hide resolved
website/docs/d/dms_certificate.html.markdown Outdated Show resolved Hide resolved
@nam054 nam054 force-pushed the f-dms-certificate-ds branch from 2ccc096 to 1276c1d Compare April 7, 2023 21:24
@nam054 nam054 merged commit a936bb1 into main Apr 7, 2023
@nam054 nam054 deleted the f-dms-certificate-ds branch April 7, 2023 22:17
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 7, 2023
github-actions bot pushed a commit that referenced this pull request Apr 7, 2023
Update CHANGELOG.md for #30498
c6e74f3
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nam054 @jar-b