Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_fis_experiment_template logging configuration #30542

Closed
akfroman opened this issue Apr 7, 2023 · 2 comments · Fixed by #32102
Closed

[Enhancement]: aws_fis_experiment_template logging configuration #30542

akfroman opened this issue Apr 7, 2023 · 2 comments · Fixed by #32102
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service.

Comments

@akfroman
Copy link

akfroman commented Apr 7, 2023

Description

The aws_fis_experiment_template doesn't seem to have a way to configure logging even though it's supported in the CLI, Cloudformation, etc

Affected Resource(s) and/or Data Source(s)

aws_fis_experiment_template

Potential Terraform Configuration

resource "aws_fis_experiment_template" "example" {
  description = "example"
  role_arn    = aws_iam_role.example.arn

  stop_condition {
    source = "none"
  }

  action {
    name      = "example-action"
    action_id = "aws:ec2:terminate-instances"

    target {
      key   = "Instances"
      value = "example-target"
    }
  }

  target {
    name           = "example-target"
    resource_type  = "aws:ec2:instance"
    selection_mode = "COUNT(1)"

    resource_tag {
      key   = "env"
      value = "example"
    }
  }

  log_configuration {  
    cloud_watch_logs_configuration = {
      log_group_arn = var.log_group_arn
    }

    s3_configuration = {
      bucket_name = var.bucket_name
      prefix = var.prefix
    }

    logSchemaVersion = var.logSchemaVersion

  }
}

References

https://awscli.amazonaws.com/v2/documentation/api/latest/reference/fis/create-experiment-template.html#:~:text=string%22%0A%20%20...%7D-,%2D%2Dlog%2Dconfiguration,-(structure)

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-fis-experimenttemplate-experimenttemplatelogconfiguration.html

Would you like to implement a fix?

No

@akfroman akfroman added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Apr 7, 2023
@github-actions github-actions bot added the service/fis Issues and PRs that pertain to the fis service. label Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 27, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fis Issues and PRs that pertain to the fis service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants