Add vpcid rds subnetgroup vpcid

[stevendborrelli]

Description

Adds vpc_id attribute to the aws_db_subnet_group resource.

Relations

N/A

References

The vpc_id is provided by the AWS SDK and already present as an attribute in the https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/db_subnet_group#vpc_id data source.

Output from Acceptance Testing

make testacc TESTS=TestAccRDSSubnetGroup_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSubnetGroup_basic'  -timeout 180m
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_basic (46.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        48.170s

Manual testing

$ terraform state show aws_db_subnet_group.default
# aws_db_subnet_group.default:
resource "aws_db_subnet_group" "default" {
    arn                     = "arn:aws:rds:us-east-1:609897127049:subgrp:main"
    description             = "Managed by Terraform"
    id                      = "main"
    name                    = "main"
    subnet_ids              = [
        "subnet-06266977967d53dfe",
        "subnet-0d639b1732687c398",
    ]
    supported_network_types = [
        "IPV4",
    ]
    tags                    = {
        "Name" = "borrelli-test-can-delete"
    }
    tags_all                = {
        "Name" = "borrelli-test-can-delete"
    }
    vpc_id                  = "vpc-0a43c06838b76d401"
}

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSSubnetGroup_ -timeout 180m
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_disappears
=== PAUSE TestAccRDSSubnetGroup_disappears
=== RUN   TestAccRDSSubnetGroup_nameGenerated
=== PAUSE TestAccRDSSubnetGroup_nameGenerated
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== RUN   TestAccRDSSubnetGroup_dualStack
=== PAUSE TestAccRDSSubnetGroup_dualStack
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== RUN   TestAccRDSSubnetGroup_updateSubnets
=== PAUSE TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroup_basic
=== CONT  TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroup_tags
--- PASS: TestAccRDSSubnetGroup_basic (28.85s)
=== CONT  TestAccRDSSubnetGroup_nameGenerated
--- PASS: TestAccRDSSubnetGroup_updateSubnets (46.00s)
=== CONT  TestAccRDSSubnetGroup_namePrefix
--- PASS: TestAccRDSSubnetGroup_nameGenerated (25.10s)
=== CONT  TestAccRDSSubnetGroup_updateDescription
--- PASS: TestAccRDSSubnetGroup_tags (61.66s)
=== CONT  TestAccRDSSubnetGroup_disappears
--- PASS: TestAccRDSSubnetGroup_namePrefix (25.50s)
=== CONT  TestAccRDSSubnetGroup_dualStack
--- PASS: TestAccRDSSubnetGroup_disappears (22.15s)
--- PASS: TestAccRDSSubnetGroup_updateDescription (41.58s)
--- PASS: TestAccRDSSubnetGroup_dualStack (42.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	119.386s

[ewbankkit]

@stevendborrelli Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.