Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoscaling/attachment: Remove alb_target_group_arn #30828

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Apr 19, 2023

Description

Relations

Closes #5407.
Closes #22904.
Relates #22662.

References

Output from Acceptance Testing

% make t T=TestAccAutoScalingAttachment_ K=autoscaling 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingAttachment_'  -timeout 180m
=== RUN   TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN   TestAccAutoScalingAttachment_multipleELBs
=== PAUSE TestAccAutoScalingAttachment_multipleELBs
=== RUN   TestAccAutoScalingAttachment_multipleALBTargetGroups
=== PAUSE TestAccAutoScalingAttachment_multipleALBTargetGroups
=== CONT  TestAccAutoScalingAttachment_elb
=== CONT  TestAccAutoScalingAttachment_multipleELBs
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingAttachment_multipleALBTargetGroups
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (36.46s)
--- PASS: TestAccAutoScalingAttachment_elb (41.82s)
--- PASS: TestAccAutoScalingAttachment_multipleALBTargetGroups (75.33s)
--- PASS: TestAccAutoScalingAttachment_multipleELBs (128.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	129.841s

Verified

This commit was signed with the committer’s verified signature.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 19, 2023
@YakDriver YakDriver changed the base branch from main to release/5.x April 19, 2023 22:35
@YakDriver YakDriver added this to the v5.0.0 milestone Apr 19, 2023
@YakDriver YakDriver added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Apr 19, 2023

Verified

This commit was signed with the committer’s verified signature.
@YakDriver YakDriver merged commit 6c50885 into release/5.x Apr 20, 2023
@YakDriver YakDriver deleted the b-autoscaling-attachment-remove-alb branch April 20, 2023 16:23
@github-actions github-actions bot modified the milestones: v5.0.0, v4.64.0 Apr 20, 2023
@YakDriver YakDriver modified the milestones: v4.64.0, v5.0.0 Apr 20, 2023
github-actions bot pushed a commit that referenced this pull request Apr 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@YakDriver YakDriver mentioned this pull request Apr 20, 2023
YakDriver pushed a commit that referenced this pull request Apr 20, 2023
@YakDriver YakDriver mentioned this pull request Apr 20, 2023
YakDriver pushed a commit that referenced this pull request Apr 20, 2023
YakDriver pushed a commit that referenced this pull request Apr 21, 2023
YakDriver pushed a commit that referenced this pull request Apr 21, 2023
johnsonaj pushed a commit that referenced this pull request Apr 21, 2023
johnsonaj pushed a commit that referenced this pull request Apr 21, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_autoscaling_attachment: incorrect parameter name "alb_target_group_arn"
1 participant