Fix aws_redshift_scheduled_action naming allowing non [0-9a-z-]{1,63}

[dscain]

Description

When creating a resource "aws_redshift_scheduled_action", the name is allowed to have any content until it reaches AWS, where upon it may be rejected due to restrictions on scheduled actions. According to AWS official documentation, there is no restriction however the API will reject non [0-9a-z-]{1,63} strings, as explained in the Redshift Schedule Action console.

References

https://docs.aws.amazon.com/cli/latest/reference/application-autoscaling/put-scheduled-action.html

Output from Acceptance Testing

$ make testacc ACCTEST_PARALLELISM=1 TESTS=TestAccRedshiftScheduledAction_validScheduleName PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 1 -run='TestAccRedshiftScheduledAction_validScheduleName'  -timeout 180m
=== RUN   TestAccRedshiftScheduledAction_validScheduleName
=== PAUSE TestAccRedshiftScheduledAction_validScheduleName
=== CONT  TestAccRedshiftScheduledAction_validScheduleName
--- PASS: TestAccRedshiftScheduledAction_validScheduleName (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   0.391s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @dscain 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftScheduledAction_basicPauseCluster$$' PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20  -run=TestAccRedshiftScheduledAction_basicPauseCluster$ -timeout 180m
=== RUN   TestAccRedshiftScheduledAction_basicPauseCluster
=== PAUSE TestAccRedshiftScheduledAction_basicPauseCluster
=== CONT  TestAccRedshiftScheduledAction_basicPauseCluster
--- PASS: TestAccRedshiftScheduledAction_basicPauseCluster (37.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	43.041s

[ewbankkit]

@dscain Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.