Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: WAFv2 ATP Response Inspection invalid parameters #31106

Closed
rasekoli opened this issue May 2, 2023 · 3 comments · Fixed by #31111
Closed

[Bug]: WAFv2 ATP Response Inspection invalid parameters #31106

rasekoli opened this issue May 2, 2023 · 3 comments · Fixed by #31111
Labels
bug Addresses a defect in current functionality. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@rasekoli
Copy link
Contributor

rasekoli commented May 2, 2023

Terraform Core Version

1.2.8

AWS Provider Version

4.64.0

Affected Resource(s)

aws_wafv2_web_acl

Expected Behavior

Resource creates successfully with all four types of response_inspection ATP parameters (body_contains, header, json, status_code)

Actual Behavior

Plan fails for three out of four response_inspection ATP parameters (body_contains, header, json).

For body_contains response inspection, the parameter success_strings is not recognised. Instead succeed_strings is expected:

Error: setting rule: Invalid address to set:
[]string{"rule", "0", "statement", "0", "managed_rule_group_statement", "0", "managed_rule_group_configs", "0",
"aws_managed_rules_atp_rule_set", "0", "response_inspection", "0", "body_contains", "0", "succeed_strings"}

For header response inspection, the parameter success_values is not recognised. Instead succeed_values is expected:

Error: setting rule: Invalid address to set:
[]string{"rule", "0", "statement", "0", "managed_rule_group_statement", "0", "managed_rule_group_configs", "0",
"aws_managed_rules_atp_rule_set", "0", "response_inspection", "0", "header", "0", "succeed_values"}

For json response inspection, the parameter success_values is not recognised. Instead succeed_values is expected:

Error: setting rule: Invalid address to set:
[]string{"rule", "0", "statement", "0", "managed_rule_group_statement", "0", "managed_rule_group_configs", "0",
"aws_managed_rules_atp_rule_set", "0", "response_inspection", "0", "json", "0", "succeed_values"}

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

atp_json.txt
atp_body_contains.txt
atp_header.txt

Steps to Reproduce

Apply the attached Terraform Configuration Files.

Debug Output

No response

Panic Output

No response

Important Factoids

Response Inspection was added in v4.63.0 in this issue #30492.

References

No response

Would you like to implement a fix?

Yes

@rasekoli rasekoli added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@ewbankkit ewbankkit added service/wafv2 Issues and PRs that pertain to the wafv2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 2, 2023
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 17, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants