Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for Kinesis Data Analytics Studio notebook #31130

Closed
cmihail opened this issue May 3, 2023 · 4 comments · Fixed by #37714
Closed

[Enhancement]: Add support for Kinesis Data Analytics Studio notebook #31130

cmihail opened this issue May 3, 2023 · 4 comments · Fixed by #37714
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service.
Milestone

Comments

@cmihail
Copy link

cmihail commented May 3, 2023

Description

Kinesis Data Analytics Studio notebook is supported by AWS::KinesisAnalyticsV2::Application via CloudFormation ApplicationMode parameter when is set to INTERACTIVE.

But terraform aws_kinesisanalyticsv2_application doesn't yet support this argument, and I get the following errors when using application_mode = "INTERACTIVE":

│ Error: Unsupported argument
│ 
│   on kinesis/analytics.tf line 190, in resource "aws_kinesisanalyticsv2_application" "account_stats":
│  190:   application_mode = "INTERACTIVE"
│ 
│ An argument named "application_mode" is not expected here.

This was my code:

resource "aws_kinesisanalyticsv2_application" "app" {
  name  = "app-name"

  runtime_environment    = "FLINK-1_13"
  service_execution_role = var.kinesis_data_app_role.arn

  application_mode = "INTERACTIVE" # Removing this line creates a normal streaming app

  tags = var.tags
}

Adding Studio app support is useful because Kinesis Data Analytics SQL app is marked as legacy by AWS, which mentions the following at https://docs.aws.amazon.com/kinesisanalytics/latest/dev/what-is.html:

For new projects, we recommend that you use the new Kinesis Data Analytics Studio over Kinesis Data Analytics for SQL Applications. Kinesis Data Analytics Studio combines ease of use with advanced analytical capabilities, enabling you to build sophisticated stream processing applications in minutes.

Affected Resource(s) and/or Data Source(s)

aws_kinesisanalyticsv2_application

Potential Terraform Configuration

resource "aws_kinesisanalyticsv2_application" "app" {
  .......

  application_mode = "INTERACTIVE" # Defaults to STREAMING
}

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kinesisanalyticsv2-application.html#cfn-kinesisanalyticsv2-application-applicationmode

Would you like to implement a fix?

None

@cmihail cmihail added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 3, 2023
@github-actions github-actions bot added the service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. label May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 3, 2023
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.52.0 milestone May 28, 2024
Copy link

This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service.
Projects
None yet
2 participants