Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Appflow JWT support for Salesforce authentication #31306

Closed
ayyappa opened this issue May 10, 2023 · 3 comments · Fixed by #34248
Closed

[Enhancement]: Appflow JWT support for Salesforce authentication #31306

ayyappa opened this issue May 10, 2023 · 3 comments · Fixed by #34248
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appflow Issues and PRs that pertain to the appflow service.
Milestone

Comments

@ayyappa
Copy link

ayyappa commented May 10, 2023

Description

Appflow Terraform support for JWT way of authentication with Salesforce. AWS recently added this feature and looking to have this update in terraform appflow api also

AWS:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/appflow/client/create_connector_profile.html

    'Salesforce': {
                                   'accessToken': 'string',
                                   'refreshToken': 'string',
                                   'oAuthRequest': {
                                                                           'authCode': 'string',
                                                                           'redirectUri': 'string'
                                    },
                                   'clientCredentialsArn': 'string',
                                   **'oAuth2GrantType': 'CLIENT_CREDENTIALS'|'AUTHORIZATION_CODE'|'JWT_BEARER',
                                   'jwtToken': 'string'**
               },

Hashicorp:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/appflow_connector_profile#salesforce-connector-profile-credentials

Salesforce Connector Profile Credentials
access_token (Optional) - The credentials used to access protected Salesforce resources.
refresh_token (Optional) - The credentials used to acquire new access tokens.
oauth_request (Optional) - The OAuth requirement needed to request security tokens from the connector endpoint. See OAuth Request for more details.
auth_code (Optional) - The code provided by the connector when it has been authenticated via the connected app.
redirect_uri (Optional) - The URL to which the authentication server redirects the browser after authorization has been granted.

client_credentials_arn (Optional) - The secret manager ARN, which contains the client ID and client secret of the connected app.

Affected Resource(s) and/or Data Source(s)

Resource: aws_appflow_connector_profile

Potential Terraform Configuration

'oAuth2GrantType': 'CLIENT_CREDENTIALS'|'AUTHORIZATION_CODE'|'JWT_BEARER',
 jwtToken': 'string'

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/appflow/client/create_connector_profile.html

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/appflow/client/create_connector_profile.html

Would you like to implement a fix?

No

@ayyappa ayyappa added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 10, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added service/appflow Issues and PRs that pertain to the appflow service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 11, 2023
@jar-b jar-b self-assigned this Nov 3, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 3, 2023
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 3, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
3 participants