Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_budgets_budget: Remove cost_filters attribute #31395

Merged
merged 3 commits into from
May 12, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 12, 2023

Description

Removes the deprecated cost_filters attribute.

Relations

Closes #31385.
Relates #22888.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccBudgetsBudget_' PKG=budgets ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 2  -run=TestAccBudgetsBudget_ -timeout 180m
=== RUN   TestAccBudgetsBudget_basic
=== PAUSE TestAccBudgetsBudget_basic
=== RUN   TestAccBudgetsBudget_Name_generated
=== PAUSE TestAccBudgetsBudget_Name_generated
=== RUN   TestAccBudgetsBudget_namePrefix
=== PAUSE TestAccBudgetsBudget_namePrefix
=== RUN   TestAccBudgetsBudget_disappears
=== PAUSE TestAccBudgetsBudget_disappears
=== RUN   TestAccBudgetsBudget_autoAdjustDataForecast
=== PAUSE TestAccBudgetsBudget_autoAdjustDataForecast
=== RUN   TestAccBudgetsBudget_autoAdjustDataHistorical
=== PAUSE TestAccBudgetsBudget_autoAdjustDataHistorical
=== RUN   TestAccBudgetsBudget_costTypes
=== PAUSE TestAccBudgetsBudget_costTypes
=== RUN   TestAccBudgetsBudget_notifications
=== PAUSE TestAccBudgetsBudget_notifications
=== RUN   TestAccBudgetsBudget_plannedLimits
=== PAUSE TestAccBudgetsBudget_plannedLimits
=== CONT  TestAccBudgetsBudget_basic
=== CONT  TestAccBudgetsBudget_autoAdjustDataHistorical
--- PASS: TestAccBudgetsBudget_basic (24.17s)
=== CONT  TestAccBudgetsBudget_notifications
--- PASS: TestAccBudgetsBudget_autoAdjustDataHistorical (45.52s)
=== CONT  TestAccBudgetsBudget_plannedLimits
--- PASS: TestAccBudgetsBudget_notifications (66.26s)
=== CONT  TestAccBudgetsBudget_disappears
--- PASS: TestAccBudgetsBudget_plannedLimits (55.81s)
=== CONT  TestAccBudgetsBudget_autoAdjustDataForecast
--- PASS: TestAccBudgetsBudget_disappears (14.97s)
=== CONT  TestAccBudgetsBudget_costTypes
--- PASS: TestAccBudgetsBudget_autoAdjustDataForecast (21.31s)
=== CONT  TestAccBudgetsBudget_namePrefix
--- PASS: TestAccBudgetsBudget_costTypes (36.83s)
=== CONT  TestAccBudgetsBudget_Name_generated
--- PASS: TestAccBudgetsBudget_namePrefix (21.92s)
--- PASS: TestAccBudgetsBudget_Name_generated (17.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	166.323s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 12, 2023
@ewbankkit ewbankkit added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label May 12, 2023
@ewbankkit ewbankkit merged commit 2f44386 into main May 12, 2023
@ewbankkit ewbankkit deleted the remove-aws_budgets_budget.cost_filters branch May 12, 2023 20:04
@github-actions github-actions bot added this to the v5.0.0 milestone May 12, 2023
github-actions bot pushed a commit that referenced this pull request May 12, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_budgets_budget: Remove cost_filters
1 participant