Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add config_parameters keys like auto_mv and query monitoring metrics to aws_redshiftserverless_workgroup #31451

Closed
meetvasu15 opened this issue May 17, 2023 · 3 comments · Fixed by #31747
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service.

Comments

@meetvasu15
Copy link

meetvasu15 commented May 17, 2023

Terraform Core Version

1.3.6

AWS Provider Version

4.34.0

Affected Resource(s)

aws_redshiftserverless_workgroup

Expected Behavior

Currently only the following config_paramters are supported,

[datestyle enable_user_activity_logging query_group search_path max_query_execution_time]

however there are more params that are supported by redshift serverless

auto_mv , enable_case_sensitivity_identifier

see config_parameters in
https://docs.aws.amazon.com/cli/latest/reference/redshift-serverless/update-workgroup.html
and

the paramaters in the following link need to be also supported
https://docs.aws.amazon.com/redshift/latest/dg/cm-c-wlm-query-monitoring-rules.html#cm-c-wlm-query-monitoring-metrics-serverless

Actual Behavior

Error: expected config_parameter.1.parameter_key to be one of [datestyle enable_user_activity_logging query_group search_path max_query_execution_time], got enable_case_sensitive_identifier

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_redshiftserverless_workgroup" "some" {
  namespace_name      = aws_redshiftserverless_namespace.some.id
  workgroup_name      = "some"
  base_capacity       = 32
  publicly_accessible = false
  subnet_ids          = data.terraform_remote_state.vpc.outputs.module_vpc_private_subnets
  security_group_ids  = [module.redshift_security_group_1.security_group_id]

  config_parameter {
    parameter_key   = "datestyle"
    parameter_value = "ISO, MDY"
  }
  config_parameter {
    parameter_key   = "enable_user_activity_logging"
    parameter_value = "true"
  }
  config_parameter {
    parameter_key   = "query_group"
    parameter_value = "default"
  }
  config_parameter {
    parameter_key   = "search_path"
    parameter_value = "$user, public"
  }
  config_parameter {
    parameter_key   = "max_query_execution_time"
    parameter_value = "200" # seconds
  }
  config_parameter {
    parameter_key="enable_case_sensitive_identifier"
    parameter_value="false"
  }
  config_parameter {
    parameter_key="auto_mv"
    parameter_value="true"
  }
  config_parameter {
    parameter_key   = "max_scan_row_count"
    parameter_value = "2000000" #  mil rows max by default
  }

 }

Steps to Reproduce

Create a new workgroup

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@meetvasu15 meetvasu15 added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 17, 2023
@github-actions github-actions bot added the service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. label May 17, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels May 17, 2023
@ewbankkit
Copy link
Contributor

Similar: #27973.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants