Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_quicksight_analysis #31542

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

comtef
Copy link
Contributor

@comtef comtef commented May 23, 2023

Description

New resource for Quicksight Analysis.

  • Definition mostly reuse underlying resources shared with Template and Dashboard.
  • Tests for basic usage, update, analysis specific attributes

Relations

Relates #10990
Closes #31666

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateAnalysis.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_UpdateAnalysis.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysis.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysisDefinition.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DescribeAnalysisPermissions.html
https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DeleteAnalysis.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccQuickSightAnalysis PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis'  -timeout 180m
=== RUN   TestAccQuickSightAnalysis_basic
=== PAUSE TestAccQuickSightAnalysis_basic
=== RUN   TestAccQuickSightAnalysis_disappears
=== PAUSE TestAccQuickSightAnalysis_disappears
=== RUN   TestAccQuickSightAnalysis_sourceEntity
=== PAUSE TestAccQuickSightAnalysis_sourceEntity
=== RUN   TestAccQuickSightAnalysis_update
=== PAUSE TestAccQuickSightAnalysis_update
=== RUN   TestAccQuickSightAnalysis_parametersConfig
=== PAUSE TestAccQuickSightAnalysis_parametersConfig
=== RUN   TestAccQuickSightAnalysis_forceDelete
=== PAUSE TestAccQuickSightAnalysis_forceDelete
=== CONT  TestAccQuickSightAnalysis_basic
=== CONT  TestAccQuickSightAnalysis_update
=== CONT  TestAccQuickSightAnalysis_forceDelete
=== CONT  TestAccQuickSightAnalysis_sourceEntity
=== CONT  TestAccQuickSightAnalysis_parametersConfig
=== CONT  TestAccQuickSightAnalysis_disappears
--- PASS: TestAccQuickSightAnalysis_forceDelete (84.90s)
--- PASS: TestAccQuickSightAnalysis_disappears (86.16s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (91.33s)
--- PASS: TestAccQuickSightAnalysis_basic (95.25s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (102.38s)
--- PASS: TestAccQuickSightAnalysis_update (135.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 135.952s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 23, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label May 30, 2023
@jar-b jar-b self-assigned this May 30, 2023
@comtef comtef force-pushed the f_quicksight_analysis branch from c83780d to 19140c2 Compare May 31, 2023 06:07
@comtef comtef marked this pull request as ready for review May 31, 2023 08:02
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTS=TestAccQuickSightAnalysis PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis'  -timeout 180m

--- PASS: TestAccQuickSightAnalysis_forceDelete (46.08s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (49.47s)
--- PASS: TestAccQuickSightAnalysis_basic (49.92s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (52.29s)
--- PASS: TestAccQuickSightAnalysis_disappears (53.85s)
--- PASS: TestAccQuickSightAnalysis_update (93.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 97.146s

@jar-b jar-b added the new-resource Introduces a new resource. label May 31, 2023
@jar-b jar-b merged commit b6b885d into hashicorp:main May 31, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_quicksight_analysis
2 participants