Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_headers to aws_amplify_app #31561

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

Maddog2050
Copy link
Contributor

Verified

This commit was signed with the committer’s verified signature.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/amplify Issues and PRs that pertain to the amplify service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 24, 2023

Verified

This commit was signed with the committer’s verified signature.
@Maddog2050 Maddog2050 marked this pull request as ready for review May 24, 2023 16:41
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@KholdStare
Copy link

@ewbankkit Anything stopping from this getting merged and released?

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

 % make testacc TESTARGS='-run=TestAccAmplify_serial/App' PKG=amplify
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 20  -run=TestAccAmplify_serial/App -timeout 360m
=== RUN   TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT  TestAccAmplify_serial
=== RUN   TestAccAmplify_serial/App
=== RUN   TestAccAmplify_serial/App/BasicAuthCredentials
    app_test.go:250: Step 1/4 error: Check failed: Check 2/3 error: aws_amplify_app.test: Attribute 'basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOkh0WmtDZHNCNWdQc2Q4N1JLZGVhQmc9PXx8U3ZaaUtHODlVTjNrVmlGbFpiV3lUK3ByTDZFcmJrc0FWTi8zT3ZWb0M2RT0="
=== RUN   TestAccAmplify_serial/App/Description
=== RUN   TestAccAmplify_serial/App/EnvironmentVariables
=== RUN   TestAccAmplify_serial/App/IamServiceRole
=== RUN   TestAccAmplify_serial/App/Repository
    app_test.go:559: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== RUN   TestAccAmplify_serial/App/basic
=== RUN   TestAccAmplify_serial/App/disappears
=== RUN   TestAccAmplify_serial/App/tags
=== RUN   TestAccAmplify_serial/App/Name
=== RUN   TestAccAmplify_serial/App/AutoBranchCreationConfig
    app_test.go:153: Step 2/5 error: Check failed: Check 3/16 error: aws_amplify_app.test: Attribute 'auto_branch_creation_config.0.basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOnV2UEJVaitjQ3hUem9FaVFwQURGZkE9PXx8cGdGak9oUnJtaXE1NmVjOWh2S3UzcCtybzd4Vk1iSzBCMmtSd1FGaG53dz0="
=== RUN   TestAccAmplify_serial/App/BuildSpec
=== RUN   TestAccAmplify_serial/App/CustomRules
--- FAIL: TestAccAmplify_serial (483.08s)
    --- FAIL: TestAccAmplify_serial/App (483.08s)
        --- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (12.53s)
        --- PASS: TestAccAmplify_serial/App/Description (57.47s)
        --- PASS: TestAccAmplify_serial/App/EnvironmentVariables (56.64s)
        --- PASS: TestAccAmplify_serial/App/IamServiceRole (57.87s)
        --- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
        --- PASS: TestAccAmplify_serial/App/basic (28.69s)
        --- PASS: TestAccAmplify_serial/App/disappears (23.40s)
        --- PASS: TestAccAmplify_serial/App/tags (59.44s)
        --- PASS: TestAccAmplify_serial/App/Name (43.45s)
        --- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (26.84s)
        --- PASS: TestAccAmplify_serial/App/BuildSpec (57.69s)
        --- PASS: TestAccAmplify_serial/App/CustomRules (59.05s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/amplify    488.617s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

@ewbankkit
Copy link
Contributor

@Maddog2050 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3336402 into hashicorp:main Oct 31, 2023
36 checks passed
@github-actions github-actions bot added this to the v5.24.0 milestone Oct 31, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/amplify Issues and PRs that pertain to the amplify service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add custom_headers to aws_amplify_app
4 participants