Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_redshift_cluster: Acceptance tests fixes #31612

Merged
merged 3 commits into from
May 30, 2023
Merged

resource/aws_redshift_cluster: Acceptance tests fixes #31612

merged 3 commits into from
May 30, 2023

Conversation

gdavison
Copy link
Contributor

Description

Fixes acceptance test failures:

  • Adds Maintenance as valid pending status in waitClusterDeleted
  • Deprecates unused parameter aqua_configuration_status

Output from Acceptance Testing

$ make testacc PKG=redshift TESTS=TestAccRedshiftCluster_

--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (8.32s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (206.18s)
--- PASS: TestAccRedshiftCluster_disappears (243.71s)
--- PASS: TestAccRedshiftCluster_iamRoles (272.16s)
--- PASS: TestAccRedshiftCluster_kmsKey (302.10s)
--- PASS: TestAccRedshiftCluster_snapshotCopy (316.21s)
--- PASS: TestAccRedshiftCluster_publiclyAccessible (360.08s)
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (377.35s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (574.18s)
--- PASS: TestAccRedshiftCluster_loggingEnabled (607.85s)
--- PASS: TestAccRedshiftCluster_basic (615.25s)
--- PASS: TestAccRedshiftCluster_aqua (438.98s)
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (648.17s)
--- PASS: TestAccRedshiftCluster_forceNewUsername (659.48s)
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (688.48s)
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (763.18s)
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (898.55s)
--- PASS: TestAccRedshiftCluster_tags (1044.81s)
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1207.14s)
--- PASS: TestAccRedshiftCluster_changeEncryption1 (1341.00s)
--- PASS: TestAccRedshiftCluster_updateNodeCount (1348.97s)
--- PASS: TestAccRedshiftCluster_updateNodeType (1573.68s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels May 27, 2023
ewbankkit
ewbankkit reviewed May 30, 2023
View reviewed changes
internal/service/redshift/cluster.go
@@ -60,6 +60,10 @@ func ResourceCluster() *schema.Resource {
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice(redshift.AquaConfigurationStatus_Values(), false),
Deprecated: "This parameter is no longer supported by the AWS API. It will be removed in the next major version of the provider.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a CHANGELOG entry for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the bug fix, too

ewbankkit
ewbankkit approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit a923fce into main May 30, 2023
@gdavison gdavison deleted the b-redshift-endpoint-access branch May 30, 2023 18:09
@github-actions github-actions bot added this to the v5.1.0 milestone May 30, 2023
github-actions bot pushed a commit that referenced this pull request May 30, 2023
Update CHANGELOG.md for #31612
e29ffea
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit