Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_endpoint: handle UnsupportedOperation tag-on-create errors #31801

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jun 6, 2023

Description

Handles errors related to tagging VPC endpoints in partitions where the operation is not supported on creation. Tagging will occur after the endpoint is created instead.

Relations

Relates #27048

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS=TestAccVPCEndpoint_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpoint_'  -timeout 180m

--- PASS: TestAccVPCEndpoint_disappears (35.67s)
--- PASS: TestAccVPCEndpoint_gatewayBasic (39.06s)
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (55.06s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (60.61s)
--- PASS: TestAccVPCEndpoint_tags (69.33s)
--- PASS: TestAccVPCEndpoint_gatewayPolicy (69.70s)
--- PASS: TestAccVPCEndpoint_interfaceBasic (140.40s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (306.47s)
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (313.97s)
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (366.59s)
--- PASS: TestAccVPCEndpoint_ipAddressType (394.01s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (450.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        453.820s

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR. labels Jun 6, 2023
@jar-b jar-b marked this pull request as ready for review June 6, 2023 21:01
@jar-b jar-b merged commit 20f7c08 into main Jun 7, 2023
@jar-b jar-b deleted the b-aws_vpc_endpoint-iso-tags-support branch June 7, 2023 14:13
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 7, 2023
github-actions bot pushed a commit that referenced this pull request Jun 7, 2023
@YakDriver YakDriver added the partition/aws-iso Pertains to the aws-iso partition. label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-iso Pertains to the aws-iso partition. service/vpc Issues and PRs that pertain to the vpc service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants