Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CREATING_SNAPSHOT status while waiting for MWAA version upgrade #31833

Conversation

MayurHadole
Copy link
Contributor

@MayurHadole MayurHadole commented Jun 8, 2023

Description

MWAA now supports in-place version upgrades.
In a successful MWAA version upgrade scenario, the status will show UPDATING, then CREATING_SNAPSHOT as Amazon MWAA captures a backup of metadata. Finally, the status will return first to UPDATING, then to AVAILABLE when the procedure is done.

This PR adds CREATING_SNAPSHOT status as a valid status along with UPDATING status when waiting for MWAA upgrade

Relations

Closes #31825.
Closes #21640.

References

https://aws.amazon.com/blogs/big-data/introducing-in-place-version-upgrades-with-amazon-mwaa/
https://docs.aws.amazon.com/mwaa/latest/userguide/upgrading-environment.html

Output from Acceptance Testing

In a successful MWAA version upgrade scenario, the status will show UPDATING, then CREATING_SNAPSHOT as Amazon MWAA captures a backup of metadata. Finally, the status will return first to UPDATING, then to AVAILABLE when the procedure is done.
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/mwaa Issues and PRs that pertain to the mwaa service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/mwaa Issues and PRs that pertain to the mwaa service. labels Jun 8, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @MayurHadole 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the service/mwaa Issues and PRs that pertain to the mwaa service. label Jun 8, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 8, 2023
@ewbankkit

This comment was marked as outdated.

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jun 8, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=360m  make testacc TESTARGS='-run=TestAccMWAAEnvironment_log\|TestAccMWAAEnvironment_pluginsS3ObjectVersion\|TestAccMWAAEnvironment_updateAirflowVersionMinor' PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_log\|TestAccMWAAEnvironment_pluginsS3ObjectVersion\|TestAccMWAAEnvironment_updateAirflowVersionMinor -timeout 360m
=== RUN   TestAccMWAAEnvironment_log
=== PAUSE TestAccMWAAEnvironment_log
=== RUN   TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== PAUSE TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== RUN   TestAccMWAAEnvironment_updateAirflowVersionMinor
=== PAUSE TestAccMWAAEnvironment_updateAirflowVersionMinor
=== CONT  TestAccMWAAEnvironment_log
=== CONT  TestAccMWAAEnvironment_updateAirflowVersionMinor
=== CONT  TestAccMWAAEnvironment_pluginsS3ObjectVersion
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (4896.54s)
--- PASS: TestAccMWAAEnvironment_log (5075.34s)
--- PASS: TestAccMWAAEnvironment_updateAirflowVersionMinor (7121.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	7127.134s

@ewbankkit
Copy link
Contributor

@MayurHadole Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 28f46b4 into hashicorp:main Jun 8, 2023
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants