[Bug]: Forced replacement of aws_vpclattice_service_network_vpc_association when using ARN as service_network_identifier

[nmoutschen]

Terraform Core Version

1.4.6

AWS Provider Version

4.67.0

Affected Resource(s)

• aws_vpclattice_service_network_vpc_association

Expected Behavior

aws_vpclattice_service_network_vpc_association should not replace resources when passing an ARN for the service_network_identifier.

According to the resource documentation passing an ARN is mandatory when using a different AWS account, thus this should never cause a problem.

Actual Behavior

Terraform will replace the aws_vpclattice_service_network_vpc_association every single time, due to the desired value (ARN) mismatching the stored value, despite them referring to the same service network.

Example with all sensitive values removed:

    # aws_vpclattice_service_network_vpc_association.this must be replaced
-/+ resource "aws_vpclattice_service_network_vpc_association" "this" {
      ~ arn                        = "arn:aws:vpc-lattice:{REGION}:{ACCOUNT_ID}:servicenetworkvpcassociation/{ASSOCIATION_ID}" -> (known after apply)
      ~ created_by                 = "{ACCOUNT_ID}" -> (known after apply)
      ~ id                         = "{ASSOCIATION_ID}" -> (known after apply)
      ~ service_network_identifier = "{SERVICE_NETWORK_ID}" -> "arn:aws:vpc-lattice:{REGION}:{ACCOUNT_ID}:servicenetwork/{SERVICE_NETWORK_ID}" # forces replacement
      ~ status                     = "ACTIVE" -> (known after apply)
        # (3 unchanged attributes hidden)
    }

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

I have not tested this example, but this should suffice to replicate the issue:

resource "aws_vpc" "this" {
  cidr_block = "10.42.0.0/16"
}

resource "aws_vpclattice_service_network" "this" {
  name      = "some_service_network"
  auth_type = "AWS_IAM"
}

resource "aws_vpclattice_service_network_vpc_association" "this" {
  vpc_identifier             = aws_vpc.this.id
  service_network_identifier = aws_vpclattice_service_network.this.arn
}

Steps to Reproduce

• Create an aws_vpclattice_service_network_vpc_association that refers to a service network by ARN
• terraform apply
• terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.