-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_lambda_provisioned_concurrency_config: Use comma-delimited id
#31933
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLambdaProvisionedConcurrencyConfig_' PKG=lambda ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 2 -run=TestAccLambdaProvisionedConcurrencyConfig_ -timeout 180m
=== RUN TestAccLambdaProvisionedConcurrencyConfig_basic
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_basic
=== RUN TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaFunction
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaFunction
=== RUN TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaProvisionedConcurrency
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaProvisionedConcurrency
=== RUN TestAccLambdaProvisionedConcurrencyConfig_provisionedConcurrentExecutions
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_provisionedConcurrentExecutions
=== RUN TestAccLambdaProvisionedConcurrencyConfig_FunctionName_arn
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_FunctionName_arn
=== RUN TestAccLambdaProvisionedConcurrencyConfig_Qualifier_aliasName
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_Qualifier_aliasName
=== RUN TestAccLambdaProvisionedConcurrencyConfig_skipDestroy
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_skipDestroy
=== RUN TestAccLambdaProvisionedConcurrencyConfig_idMigration530
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_idMigration530
=== CONT TestAccLambdaProvisionedConcurrencyConfig_basic
=== CONT TestAccLambdaProvisionedConcurrencyConfig_FunctionName_arn
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_basic (199.23s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaProvisionedConcurrency
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_FunctionName_arn (311.84s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_provisionedConcurrentExecutions
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaProvisionedConcurrency (194.37s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaFunction
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_Disappears_lambdaFunction (213.91s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_skipDestroy
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_provisionedConcurrentExecutions (383.35s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_idMigration530
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_idMigration530 (207.68s)
=== CONT TestAccLambdaProvisionedConcurrencyConfig_Qualifier_aliasName
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_skipDestroy (419.16s)
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_Qualifier_aliasName (198.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 1106.541s
This functionality has been released in v5.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Updates the resource
id
to a comma-separated string, joiningfunction_name
andqualifier
. This allows thefunction_name
argument to reliably accept ARN values which previously caused Read operations to fail, and migrates this resource to the preferred ID separator.Relations
Fixes #11152
Fixes #12923
Fixes #22392
Closes #19868
Closes #11679
Closes #22808
Relates #27843
Output from Acceptance Testing