Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support to AWS config to configuration recorder to support recording strategy #32007

Closed
lafod opened this issue Jun 15, 2023 · 3 comments · Fixed by #32066
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service.
Milestone

Comments

@lafod
Copy link
Contributor

lafod commented Jun 15, 2023

Description

AWS config now support recording exclusion of resource type by specifying a recording strategy for the configuration recorder. this enhancement would make it possible to specify recording strategy of types defined below

  • ALL_SUPPORTED_RESOURCE_TYPES, AWS Config records configuration changes for all supported regional resource types.
  • INCLUSION_BY_RESOURCE_TYPES, AWS Config records configuration changes for only the resource types you specify in the resourceTypes
  • EXCLUSION_BY_RESOURCE_TYPES, AWS Config records configuration changes for all supported resource types except the resource types that you specify as exemptions to exclude from being recorded in the resourceTypes

Affected Resource(s) and/or Data Source(s)

aws_config_configuration_recorder

Potential Terraform Configuration

resource "aws_config_configuration_recorder" "foo" {
  name     = "example"
  role_arn = aws_iam_role.r.arn
  recording_group {
    all_supported = false 
    exclusion_by_resource_types = [ "AWS::EC2::Instance" ]
    recording_strategy {
      use_only="EXCLUSION_BY_RESOURCE_TYPES"
    }
}

data "aws_iam_policy_document" "assume_role" {
  statement {
    effect = "Allow"

    principals {
      type        = "Service"
      identifiers = ["config.amazonaws.com"]
    }

    actions = ["sts:AssumeRole"]
  }
}

resource "aws_iam_role" "r" {
  name               = "awsconfig-example"
  assume_role_policy = data.aws_iam_policy_document.assume_role.json
}

References

https://aws.amazon.com/about-aws/whats-new/2023/06/aws-config-recording-exclusions-resource-type/
https://docs.aws.amazon.com/config/latest/APIReference/API_PutConfigurationRecorder.html

Would you like to implement a fix?

Yes

@lafod lafod added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jun 15, 2023
@github-actions github-actions bot added service/configservice Issues and PRs that pertain to the configservice service. service/iam Issues and PRs that pertain to the iam service. labels Jun 15, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. labels Jun 15, 2023
@github-actions github-actions bot added this to the v5.5.0 milestone Jun 21, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants