Improve doc accuracy for aws_vpc_security_group_ingress_rule and `a…

[mattburgess]

…ws_vpc_security_group_egress_rule`

• ip_protocol was marked as Required in the schema but Optional in the docs
• security_group_id is Required but was Optional in the schema
• Try to clarify the situations where Optional arguments are actually Required

Description

Relations

Closes #29895
Closes #32089
Relates #29893

References

Note that although this technically includes what looks like a breaking change, it's impossible for practitioners to create security group rules without specifying a security group ID so this is actually just a quality-of-life improvement by getting early validation feedback without waiting for the AWS API call to be made.

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[justinretzolk]

I've got a couple of minor suggestions, but overall this looks great to me. Thanks for taking the time to do this!

I saw you'd discussed this a bit on #32089 too. I'm happy to add the commits, but based on what you'd already looked at, could we update the aws_security_group resource documentation with what you've already written here?

[mattburgess]

I've got a couple of minor suggestions, but overall this looks great to me. Thanks for taking the time to do this!

I saw you'd discussed this a bit on #32089 too. I'm happy to add the commits, but based on what you'd already looked at, could we update the aws_security_group resource documentation with what you've already written here?

Sure, I've also updated aws_security_group_rule too. Thanks for the super quick review!

[github-actions]

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.