-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: step function alias and versioning #32176
Conversation
Community NoteVoting for Prioritization
For Submitters
|
47c4df6
to
099bd8c
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…-value-pointer-conversion'.
…k lines [Expected: 1; Actual: 2]'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSFN' PKG=sfn ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 2 -run=TestAccSFN -timeout 180m
=== RUN TestAccSFNActivityDataSource_basic
=== PAUSE TestAccSFNActivityDataSource_basic
=== RUN TestAccSFNActivity_basic
=== PAUSE TestAccSFNActivity_basic
=== RUN TestAccSFNActivity_disappears
=== PAUSE TestAccSFNActivity_disappears
=== RUN TestAccSFNActivity_tags
=== PAUSE TestAccSFNActivity_tags
=== RUN TestAccSFNAliasDataSource_basic
=== PAUSE TestAccSFNAliasDataSource_basic
=== RUN TestAccSFNAlias_basic
=== PAUSE TestAccSFNAlias_basic
=== RUN TestAccSFNAlias_disappears
=== PAUSE TestAccSFNAlias_disappears
=== RUN TestAccSFNStateMachineDataSource_basic
=== PAUSE TestAccSFNStateMachineDataSource_basic
=== RUN TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN TestAccSFNStateMachine_publish
=== PAUSE TestAccSFNStateMachine_publish
=== RUN TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== RUN TestAccSFNStateMachineVersionsDataSource_basic
=== PAUSE TestAccSFNStateMachineVersionsDataSource_basic
=== CONT TestAccSFNActivityDataSource_basic
=== CONT TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNActivityDataSource_basic (21.90s)
=== CONT TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNStateMachine_standardUpdate (98.40s)
=== CONT TestAccSFNAlias_basic
--- PASS: TestAccSFNStateMachine_tracing (150.82s)
=== CONT TestAccSFNStateMachineVersionsDataSource_basic
--- PASS: TestAccSFNAlias_basic (90.43s)
=== CONT TestAccSFNStateMachine_publish
--- PASS: TestAccSFNStateMachineVersionsDataSource_basic (77.80s)
=== CONT TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_publish (114.30s)
=== CONT TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_expressLogging (113.71s)
=== CONT TestAccSFNStateMachine_namePrefix
--- PASS: TestAccSFNStateMachine_disappears (112.16s)
=== CONT TestAccSFNStateMachine_nameGenerated
--- PASS: TestAccSFNStateMachine_namePrefix (93.98s)
=== CONT TestAccSFNActivity_tags
--- PASS: TestAccSFNStateMachine_nameGenerated (161.41s)
=== CONT TestAccSFNAliasDataSource_basic
--- PASS: TestAccSFNActivity_tags (144.22s)
=== CONT TestAccSFNStateMachine_tags
--- PASS: TestAccSFNAliasDataSource_basic (96.11s)
=== CONT TestAccSFNStateMachine_createUpdate
--- PASS: TestAccSFNStateMachine_tags (202.61s)
=== CONT TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (159.86s)
=== CONT TestAccSFNActivity_disappears
--- PASS: TestAccSFNActivity_disappears (20.28s)
=== CONT TestAccSFNActivity_basic
--- PASS: TestAccSFNActivity_basic (66.38s)
=== CONT TestAccSFNStateMachineDataSource_basic
--- PASS: TestAccSFNStateMachine_expressUpdate (148.80s)
=== CONT TestAccSFNAlias_disappears
--- PASS: TestAccSFNStateMachineDataSource_basic (135.14s)
--- PASS: TestAccSFNAlias_disappears (135.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 1095.097s
…-value-pointer-conversion'.
This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for Step function alias and versioning
Relations
Closes #32175.
Closes #32190.
Requires AWS SDK for Go v1.44.288: #32183.
References
https://aws.amazon.com/blogs/compute/deploying-state-machines-incrementally-with-versions-and-aliases-in-aws-step-functions/
Output from Acceptance Testing