Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

medialive/channel: implement additional encoder settings #32233

Merged

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Jun 27, 2023

Description

Adds schemas for caption_descriptions, global_configuration, motion_graphics_configuration, and nielsen_configuration support in medialive channel encoder settings.

Relates #27824.

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/medialive/client/create_channel.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/medialive@v1.31.6/types#EncoderSettings

Output from Acceptance Testing

I lack privileges (AWS IAM policies) to run acceptance tests.

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/medialive Issues and PRs that pertain to the medialive service. needs-triage Waiting for first response or review from a maintainer. labels Jun 27, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gbw 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 27, 2023
@johnsonaj johnsonaj self-assigned this Jul 3, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccMediaLiveChannel_' PKG=medialive

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20  -run=TestAccMediaLiveChannel_ -timeout 180m
--- PASS: TestAccMediaLiveChannel_MsSmooth_outputSettings (89.95s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h264Settings (103.66s)
--- PASS: TestAccMediaLiveChannel_update (107.57s)
--- PASS: TestAccMediaLiveChannel_UDP_outputSettings (115.66s)
--- PASS: TestAccMediaLiveChannel_hls (155.54s)
--- PASS: TestAccMediaLiveChannel_M2TS_settings (171.88s)
--- PASS: TestAccMediaLiveChannel_disappears (193.28s)
--- PASS: TestAccMediaLiveChannel_status (194.24s)
--- PASS: TestAccMediaLiveChannel_updateTags (210.05s)
--- PASS: TestAccMediaLiveChannel_AudioDescriptions_codecSettings (229.17s)
--- PASS: TestAccMediaLiveChannel_captionDescriptions (241.74s)
--- PASS: TestAccMediaLiveChannel_basic (276.71s)
--- PASS: TestAccMediaLiveChannel_VideoDescriptions_CodecSettings_h265Settings (276.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	279.675s

@johnsonaj
Copy link
Contributor

@gbw thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 29dbd11 into hashicorp:main Jul 25, 2023
@github-actions github-actions bot added this to the v5.10.0 milestone Jul 25, 2023
@github-actions
Copy link

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
@gbw gbw deleted the implement_medialive_channel_encoder_settings branch October 21, 2023 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/medialive Issues and PRs that pertain to the medialive service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants