-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech debt: Migrate internetmonitor
resources to AWS SDK for Go v2
#32343
Conversation
….0 && go mod tidy'.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=internetmonitor TESTS=TestAccInternetMonitorMonitor_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/internetmonitor/... -v -count 1 -parallel 20 -run='TestAccInternetMonitorMonitor_' -timeout 180m
=== RUN TestAccInternetMonitorMonitor_basic
=== PAUSE TestAccInternetMonitorMonitor_basic
=== RUN TestAccInternetMonitorMonitor_log
=== PAUSE TestAccInternetMonitorMonitor_log
=== RUN TestAccInternetMonitorMonitor_disappears
=== PAUSE TestAccInternetMonitorMonitor_disappears
=== RUN TestAccInternetMonitorMonitor_tags
=== PAUSE TestAccInternetMonitorMonitor_tags
=== CONT TestAccInternetMonitorMonitor_basic
=== CONT TestAccInternetMonitorMonitor_disappears
=== CONT TestAccInternetMonitorMonitor_log
=== CONT TestAccInternetMonitorMonitor_tags
--- PASS: TestAccInternetMonitorMonitor_log (44.93s)
--- PASS: TestAccInternetMonitorMonitor_disappears (47.92s)
--- PASS: TestAccInternetMonitorMonitor_basic (60.57s)
--- PASS: TestAccInternetMonitorMonitor_tags (155.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/internetmonitor 158.740s
internermonitor
resources to AWS SDK for Go v2internetmonitor
resources to AWS SDK for Go v2
This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Also adds the
health_events_config
configuration block.Output from Acceptance Testing