-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F codecatalyst devenv #32366
F codecatalyst devenv #32366
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
hi @ewbankkit do you want me to create a new pull request for this new service to fix all those conflics in a cleaner code? |
Fixed conflict
@markoskandylis Thanks for the contribution 🎉 👏. |
@ewbankkit thanks i will do this change tomorrow there are couple of more resources coming for this service as well :) thanks for the help :) |
hi @ewbankkit Here is the new tests with the new name make testacc TESTARGS='-run=TestAccCodeCatalystDevEnvironment_' PKG=codecatalyst ACCTEST_PARALLELISM=3 |
# Conflicts: # go.mod # go.sum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeCatalystDevEnvironment_' PKG=codecatalyst
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecatalyst/... -v -count 1 -parallel 20 -run=TestAccCodeCatalystDevEnvironment_ -timeout 180m
=== RUN TestAccCodeCatalystDevEnvironment_basic
=== PAUSE TestAccCodeCatalystDevEnvironment_basic
=== RUN TestAccCodeCatalystDevEnvironment_withRepositories
=== PAUSE TestAccCodeCatalystDevEnvironment_withRepositories
=== RUN TestAccCodeCatalystDevEnvironment_disappears
=== PAUSE TestAccCodeCatalystDevEnvironment_disappears
=== CONT TestAccCodeCatalystDevEnvironment_basic
=== CONT TestAccCodeCatalystDevEnvironment_disappears
=== CONT TestAccCodeCatalystDevEnvironment_withRepositories
=== NAME TestAccCodeCatalystDevEnvironment_disappears
dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
=== NAME TestAccCodeCatalystDevEnvironment_withRepositories
dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
--- SKIP: TestAccCodeCatalystDevEnvironment_withRepositories (0.44s)
--- SKIP: TestAccCodeCatalystDevEnvironment_disappears (0.44s)
=== NAME TestAccCodeCatalystDevEnvironment_basic
dev_environment_test.go:190: skipping acceptance testing: runtime error: invalid memory address or nil pointer dereference
--- SKIP: TestAccCodeCatalystDevEnvironment_basic (0.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codecatalyst 6.013s
@markoskandylis Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for CodeCatalyst Dev Environment
Relations
Closes #31286
References
go reference: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/codecatalyst
sdk reference: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/clients/client-codecatalyst/
Output from Acceptance Testing