Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lb_listener_certificate: remove from state if listener not found #32412

Conversation

lomluca
Copy link
Contributor

@lomluca lomluca commented Jul 7, 2023

Description

Currently, if the listener (or the Load Balancer) has been removed by an external actor, the plan does not work due to "ListenerNotFound" error by AWS API.
The correct behaviour is that the resource is removed from state, and it will be eventually created again if it is still in the configuration.

Relations

Closes #30489

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@lomluca lomluca force-pushed the b-aws_lb_listener_certificate-fix-listener-not-found branch from a734e5d to 7fa221a Compare July 7, 2023 14:30
@lomluca lomluca changed the title [WIP] r/aws_lb_listener_certificate: remove from state if listener not found r/aws_lb_listener_certificate: remove from state if listener not found Jul 7, 2023
@lomluca lomluca marked this pull request as ready for review July 7, 2023 14:31
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 7, 2023
@jar-b jar-b self-assigned this Aug 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 11, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=elbv2 TESTS=TestAccELBV2ListenerCertificate_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerCertificate_'  -timeout 180m

--- PASS: TestAccELBV2ListenerCertificate_disappears (150.33s)
--- PASS: TestAccELBV2ListenerCertificate_basic (164.35s)
--- PASS: TestAccELBV2ListenerCertificate_CertificateARN_underscores (164.48s)
--- PASS: TestAccELBV2ListenerCertificate_disappears_Listener (169.53s)
--- PASS: TestAccELBV2ListenerCertificate_multiple (225.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      228.940s

@jar-b jar-b merged commit c0bbba1 into hashicorp:main Aug 11, 2023
34 checks passed
@jar-b
Copy link
Member

jar-b commented Aug 11, 2023

Thanks for your contribution, @lomluca! 👏

@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 18, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fails on reading ELB Listener Certificate of removed Listener during terraform plan
3 participants