-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misidentification of parent folder at grandchild level or deeper. #32592
Fix misidentification of parent folder at grandchild level or deeper. #32592
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @yosuke310 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=quicksight TESTS=TestAccQuickSightFolder_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolder_' -timeout 180m
? github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema [no test files]
--- PASS: TestAccQuickSightFolder_disappears (19.35s)
--- PASS: TestAccQuickSightFolder_basic (25.99s)
--- PASS: TestAccQuickSightFolder_parentFolder (47.89s)
--- PASS: TestAccQuickSightFolder_parentFolderNested (48.89s)
--- PASS: TestAccQuickSightFolder_tags (56.20s)
--- PASS: TestAccQuickSightFolder_permissions (65.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 69.140s
Thanks for your contribution, @yosuke310! 👏 |
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Bug fix for
aws_quicksight_folder
.FolderPath
seems to be ordered by older ancestors, this change ensures the correct parent folder is used.Relations
Closes #31922
Output from Acceptance Testing