Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misidentification of parent folder at grandchild level or deeper. #32592

Merged

Conversation

yosuke310
Copy link
Contributor

Description

Bug fix for aws_quicksight_folder.
FolderPath seems to be ordered by older ancestors, this change ensures the correct parent folder is used.

Relations

Closes #31922

Output from Acceptance Testing

make testacc TESTS=TestAccQuickSightFolder_ PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolder_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightFolder_basic
=== PAUSE TestAccQuickSightFolder_basic
=== RUN   TestAccQuickSightFolder_disappears
=== PAUSE TestAccQuickSightFolder_disappears
=== RUN   TestAccQuickSightFolder_permissions
=== PAUSE TestAccQuickSightFolder_permissions
=== RUN   TestAccQuickSightFolder_tags
=== PAUSE TestAccQuickSightFolder_tags
=== RUN   TestAccQuickSightFolder_parentFolder
=== PAUSE TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_basic
=== CONT  TestAccQuickSightFolder_tags
=== CONT  TestAccQuickSightFolder_permissions
=== CONT  TestAccQuickSightFolder_parentFolder
=== CONT  TestAccQuickSightFolder_disappears
--- PASS: TestAccQuickSightFolder_disappears (31.16s)
--- PASS: TestAccQuickSightFolder_basic (39.88s)
--- PASS: TestAccQuickSightFolder_parentFolder (69.81s)
--- PASS: TestAccQuickSightFolder_tags (82.15s)
--- PASS: TestAccQuickSightFolder_permissions (98.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 101.579s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. needs-triage Waiting for first response or review from a maintainer. labels Jul 19, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @yosuke310 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Jul 20, 2023
@jar-b jar-b self-assigned this Jul 20, 2023
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 20, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightFolder_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightFolder_'  -timeout 180m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightFolder_disappears (19.35s)
--- PASS: TestAccQuickSightFolder_basic (25.99s)
--- PASS: TestAccQuickSightFolder_parentFolder (47.89s)
--- PASS: TestAccQuickSightFolder_parentFolderNested (48.89s)
--- PASS: TestAccQuickSightFolder_tags (56.20s)
--- PASS: TestAccQuickSightFolder_permissions (65.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 69.140s

@jar-b jar-b merged commit db5ffa9 into hashicorp:main Jul 20, 2023
@jar-b
Copy link
Member

jar-b commented Jul 20, 2023

Thanks for your contribution, @yosuke310! 👏

@github-actions github-actions bot added this to the v5.9.0 milestone Jul 20, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@yosuke310 yosuke310 deleted the b-aws_quicksight_folder-correct-parent-forder branch July 21, 2023 00:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/quicksight Issues and PRs that pertain to the quicksight service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_quicksight_folder - trigger force recreation by inconsistent parent_folder_arn property
2 participants