-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_grafana_workspace: Allow in-place version updates #32679
r/aws_grafana_workspace: Allow in-place version updates #32679
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/version' PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run=TestAccGrafana_serial/Workspace/version -timeout 180m
=== RUN TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT TestAccGrafana_serial
=== RUN TestAccGrafana_serial/Workspace
=== RUN TestAccGrafana_serial/Workspace/version
--- PASS: TestAccGrafana_serial (684.79s)
--- PASS: TestAccGrafana_serial/Workspace (684.79s)
--- PASS: TestAccGrafana_serial/Workspace/version (684.79s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 689.725s
% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/saml' PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run=TestAccGrafana_serial/Workspace/saml -timeout 180m
=== RUN TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT TestAccGrafana_serial
=== RUN TestAccGrafana_serial/Workspace
=== RUN TestAccGrafana_serial/Workspace/saml
--- PASS: TestAccGrafana_serial (444.62s)
--- PASS: TestAccGrafana_serial/Workspace (444.62s)
--- PASS: TestAccGrafana_serial/Workspace/saml (444.62s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 449.102s
@phyber Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR updates the
aws_grafana_workspace
resource to allow in-place updates of the Grafana Version.Relations
There don't seem to be any issues related to this.
References
The AWS API was updated to allow in-place upgrades of the workspace on or around July 19th (blog post, API documentation).
Output from Acceptance Testing
I have not been able to run the acceptance testing for this PR, as I'm unsure how to modify the acceptance tests to test an in-place upgrade. I have located the existing
testAccWorkspace_version
test and read the documentation, but I didn't find the documentation particularly useful in this case. Sorry.