Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ec2_transit_gateway_vpc_attachment: transit_gateway_default_route_table_association is Computed #32821

Merged
merged 8 commits into from
Aug 3, 2023
Merged

r/aws_ec2_transit_gateway_vpc_attachment: transit_gateway_default_route_table_association is Computed #32821

merged 8 commits into from
Aug 3, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 2, 2023 •
edited
Loading

Description

Changes transit_gateway_default_route_table_association and transit_gateway_default_route_table_propagation to Computed, preserving the default values of true on Create.

Relations

Closes #21438.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^VpcAttachment$$\|TestAccTransitGatewayDataSource_serial/^VpcAttachment$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^VpcAttachment$\|TestAccTransitGatewayDataSource_serial/^VpcAttachment$ -timeout 180m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGatewayDataSource_serial/VpcAttachment
=== RUN   TestAccTransitGatewayDataSource_serial/VpcAttachment/Filter
=== RUN   TestAccTransitGateway_serial/VpcAttachment
=== RUN   TestAccTransitGateway_serial/VpcAttachment/SubnetIds
=== RUN   TestAccTransitGatewayDataSource_serial/VpcAttachment/ID
=== RUN   TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTablePropagation
--- PASS: TestAccTransitGatewayDataSource_serial (476.16s)
    --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment (476.16s)
        --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment/Filter (229.17s)
        --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment/ID (246.98s)
=== RUN   TestAccTransitGateway_serial/VpcAttachment/basic
=== RUN   TestAccTransitGateway_serial/VpcAttachment/disappears
=== RUN   TestAccTransitGateway_serial/VpcAttachment/tags
=== RUN   TestAccTransitGateway_serial/VpcAttachment/DnsSupport
=== RUN   TestAccTransitGateway_serial/VpcAttachment/Ipv6Support
=== RUN   TestAccTransitGateway_serial/VpcAttachment/ApplianceModeSupport
=== RUN   TestAccTransitGateway_serial/VpcAttachment/SharedTransitGateway
    acctest.go:804: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociation
=== RUN   TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled
--- PASS: TestAccTransitGateway_serial (2945.03s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment (2945.03s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/SubnetIds (417.80s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTablePropagation (323.71s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/basic (241.59s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/disappears (215.00s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/tags (291.47s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/DnsSupport (298.42s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/Ipv6Support (280.14s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/ApplianceModeSupport (300.17s)
        --- SKIP: TestAccTransitGateway_serial/VpcAttachment/SharedTransitGateway (0.00s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociation (387.26s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (189.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2949.980s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/^RouteTableAssociation$$\|TestAccTransitGateway_serial/^RouteTablePropagation$$\|TestAccTransitGatewayDataSource_serial/^RouteTableAssociations$$\|TestAccTransitGatewayDataSource_serial/^RouteTablePropagations$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^RouteTableAssociation$\|TestAccTransitGateway_serial/^RouteTablePropagation$\|TestAccTransitGatewayDataSource_serial/^RouteTableAssociations$\|TestAccTransitGatewayDataSource_serial/^RouteTablePropagations$ -timeout 180m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTableAssociations
=== RUN   TestAccTransitGateway_serial/RouteTableAssociation
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTableAssociations/Filter
=== RUN   TestAccTransitGateway_serial/RouteTableAssociation/ReplaceExistingAssociation
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTableAssociations/basic
=== RUN   TestAccTransitGateway_serial/RouteTableAssociation/basic
=== RUN   TestAccTransitGateway_serial/RouteTableAssociation/disappears
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTablePropagations
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTablePropagations/Filter
=== RUN   TestAccTransitGatewayDataSource_serial/RouteTablePropagations/basic
=== RUN   TestAccTransitGateway_serial/RouteTablePropagation
=== RUN   TestAccTransitGateway_serial/RouteTablePropagation/basic
--- PASS: TestAccTransitGatewayDataSource_serial (1162.39s)
    --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations (658.57s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations/Filter (349.85s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations/basic (308.72s)
    --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations (503.81s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations/Filter (267.27s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations/basic (236.54s)
=== RUN   TestAccTransitGateway_serial/RouteTablePropagation/disappears
--- PASS: TestAccTransitGateway_serial (1495.03s)
    --- PASS: TestAccTransitGateway_serial/RouteTableAssociation (977.71s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/ReplaceExistingAssociation (383.41s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/basic (266.04s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/disappears (328.26s)
    --- PASS: TestAccTransitGateway_serial/RouteTablePropagation (517.32s)
        --- PASS: TestAccTransitGateway_serial/RouteTablePropagation/basic (250.21s)
        --- PASS: TestAccTransitGateway_serial/RouteTablePropagation/disappears (267.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1499.947s

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/transitgateway Issues and PRs that pertain to the transitgateway service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 2, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 2, 2023
@jar-b jar-b self-assigned this Aug 2, 2023
jar-b
jar-b approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccTransitGateway_serial/^VpcAttachment$$\|TestAccTransitGatewayDataSource_serial/^VpcAttachment$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^VpcAttachment$\|TestAccTransitGatewayDataSource_serial/^VpcAttachment$ -timeout 180m

--- PASS: TestAccTransitGatewayDataSource_serial (517.95s)
    --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment (517.95s)
        --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment/Filter (238.83s)
        --- PASS: TestAccTransitGatewayDataSource_serial/VpcAttachment/ID (279.13s)

--- PASS: TestAccTransitGateway_serial (2846.09s)
    --- PASS: TestAccTransitGateway_serial/VpcAttachment (2846.09s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/ApplianceModeSupport (231.90s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/DnsSupport (311.64s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/Ipv6Support (331.40s)
        --- SKIP: TestAccTransitGateway_serial/VpcAttachment/SharedTransitGateway (0.00s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociation (349.33s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTablePropagation (274.67s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/basic (240.85s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/tags (295.99s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/SubnetIds (403.06s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/TransitGatewayDefaultRouteTableAssociationAndPropagationDisabled (179.65s)
        --- PASS: TestAccTransitGateway_serial/VpcAttachment/disappears (227.58s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        2849.052s
$ make testacc TESTARGS='-run=TestAccTransitGateway_serial/^RouteTableAssociation$$\|TestAccTransitGateway_serial/^RouteTablePropagation$$\|TestAccTransitGatewayDataSource_serial/^RouteTableAssociations$$\|TestAccTransitGatewayDataSource_serial/^RouteTablePropagations$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/^RouteTableAssociation$\|TestAccTransitGateway_serial/^RouteTablePropagation$\|TestAccTransitGatewayDataSource_serial/^RouteTableAssociations$\|TestAccTransitGatewayDataSource_serial/^RouteTablePropagations$ -timeout 180m

--- PASS: TestAccTransitGatewayDataSource_serial (1135.68s)
    --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations (679.55s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations/Filter (350.27s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTableAssociations/basic (329.28s)
    --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations (456.13s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations/Filter (238.09s)
        --- PASS: TestAccTransitGatewayDataSource_serial/RouteTablePropagations/basic (218.03s)

--- PASS: TestAccTransitGateway_serial (1504.60s)
    --- PASS: TestAccTransitGateway_serial/RouteTableAssociation (983.08s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/basic (353.06s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/disappears (329.09s)
        --- PASS: TestAccTransitGateway_serial/RouteTableAssociation/ReplaceExistingAssociation (300.93s)
    --- PASS: TestAccTransitGateway_serial/RouteTablePropagation (521.52s)
        --- PASS: TestAccTransitGateway_serial/RouteTablePropagation/basic (241.36s)
        --- PASS: TestAccTransitGateway_serial/RouteTablePropagation/disappears (280.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1507.430s

@ewbankkit ewbankkit merged commit f11fd07 into main Aug 3, 2023
@ewbankkit ewbankkit deleted the b-r/aws_ec2_transit_gateway_vpc_attachment.transit_gateway_default_route_table_association-diff branch August 3, 2023 13:06
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 3, 2023
github-actions bot pushed a commit that referenced this pull request Aug 3, 2023
Update CHANGELOG.md for #32821
4f6935f
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.11.0
Development

Successfully merging this pull request may close these issues.

aws_ec2_transit_gateway_vpc_attachment does not respect setting default route table options to false
2 participants
@ewbankkit @jar-b