Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SNS: Add support for DeliveryPolicy in SNS topic subscriptions #3288

Closed
ddcprg opened this issue Feb 8, 2018 · 2 comments · Fixed by #3289
Closed

AWS SNS: Add support for DeliveryPolicy in SNS topic subscriptions #3288

ddcprg opened this issue Feb 8, 2018 · 2 comments · Fixed by #3289
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Milestone

Comments

@ddcprg
Copy link
Contributor

ddcprg commented Feb 8, 2018

Add support for DeliveryPolicy in SNS topic subscriptions.

See [SNS FAQ|https://aws.amazon.com/sns/faqs/] for details: What happens to Amazon SNS messages if the subscribing endpoint is not available?

Terraform Version

All

Affected Resource(s)

  • aws_sns_topic_subscription

Expected Behavior

The delivery policy should applied to the SNS subscription if the subscription is HTTP/S. Otherwise, it must be rejected.

Actual Behavior

The attribute delivery_policy is there but is not implemented - only read after resource creation.

References

#2916

@vancluever vancluever added enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. labels Feb 8, 2018
@ddcprg ddcprg changed the title AWS SNS: Add support for DeliveryPolicy in SNS topic subscriptions AWS SNS: Add support for DeliveryPolicy in SNS topic subscriptions Feb 8, 2018
@bflad bflad added this to the v1.39.0 milestone Sep 28, 2018
@bflad
Copy link
Contributor

bflad commented Sep 28, 2018

The initial implementation of the delivery_policy argument has been merged and will release with version 1.39.0 of the AWS provider, likely middle of next week.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service.
Projects
None yet
3 participants