[TechDebt]: Fix appstream acceptance tests

[jar-b]

Description

Fixes various AppStream acceptances tests which were failing due to the use of deprecated image names. Also updates associated documentation where applicable.

=== RUN   TestAccAppStreamFleet_basic
=== PAUSE TestAccAppStreamFleet_basic
=== CONT  TestAccAppStreamFleet_basic
    fleet_test.go:41: Step 1/2 error: Error running apply: exit status 1
        Error: creating Appstream Fleet (): ResourceNotAvailableException: The image Amazon-AppStream2-Sample-Image-02-04-2019 is DEPRECATED. The image must be in an AVAILABLE state for this action to succeed.
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 2, in resource "aws_appstream_fleet" "test":
           2: resource "aws_appstream_fleet" "test" {
--- FAIL: TestAccAppStreamFleet_basic (65.75s)
FAIL

=== RUN   TestAccAppStreamFleetStackAssociation_basic
=== PAUSE TestAccAppStreamFleetStackAssociation_basic
=== CONT  TestAccAppStreamFleetStackAssociation_basic
    fleet_stack_association_test.go:26: Step 1/2 error: Error running apply: exit status 1
        Error: creating Appstream Fleet (): ResourceNotAvailableException: The image Amazon-AppStream2-Sample-Image-02-04-2019 is DEPRECATED. The image must be in an AVAILABLE state for this action to succeed.
          with aws_appstream_fleet.test,
          on terraform_plugin_test.tf line 2, in resource "aws_appstream_fleet" "test":
           2: resource "aws_appstream_fleet" "test" {
--- FAIL: TestAccAppStreamFleetStackAssociation_basic (82.31s)
FAIL

=== RUN   TestAccAppStreamImageBuilder_basic
=== PAUSE TestAccAppStreamImageBuilder_basic
=== CONT  TestAccAppStreamImageBuilder_basic
    image_builder_test.go:27: Step 1/2 error: Error running apply: exit status 1
        Error: creating AppStream ImageBuilder (tf-acc-test-638513868540127945): ResourceNotAvailableException: The image AppStream-WinServer2019-07-12-2022 is DEPRECATED. The image must be in an AVAILABLE state for this action to succeed.
          with aws_appstream_image_builder.test,
          on terraform_plugin_test.tf line 2, in resource "aws_appstream_image_builder" "test":
           2: resource "aws_appstream_image_builder" "test" {
--- FAIL: TestAccAppStreamImageBuilder_basic (50.02s)
FAIL

Relations

Relates #22536

References

• https://docs.aws.amazon.com/appstream2/latest/developerguide/base-image-version-history.html

Output from Acceptance Testing

% make testacc PKG=appstream TESTS=TestAccAppStreamFleet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleet_'  -timeout 180m

--- PASS: TestAccAppStreamFleet_disappears (784.13s)
--- PASS: TestAccAppStreamFleet_basic (891.98s)
--- PASS: TestAccAppStreamFleet_completeWithoutStop (894.78s)
--- PASS: TestAccAppStreamFleet_emptyDomainJoin (894.97s)
--- PASS: TestAccAppStreamFleet_withTags (960.38s)
--- PASS: TestAccAppStreamFleet_completeWithStop (1766.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1769.666s

% make testacc PKG=appstream TESTS=TestAccAppStreamFleetStackAssociation_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamFleetStackAssociation_'  -timeout 180m

--- PASS: TestAccAppStreamFleetStackAssociation_basic (817.79s)
--- PASS: TestAccAppStreamFleetStackAssociation_disappears (856.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  859.473s

% make testacc PKG=appstream TESTS=TestAccAppStreamImageBuilder_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamImageBuilder_'  -timeout 180m

--- PASS: TestAccAppStreamImageBuilder_withIAMRole (702.87s)
--- PASS: TestAccAppStreamImageBuilder_disappears (727.45s)
--- PASS: TestAccAppStreamImageBuilder_basic (1016.75s)
--- PASS: TestAccAppStreamImageBuilder_imageARN (1026.53s)
--- PASS: TestAccAppStreamImageBuilder_tags (1036.58s)
--- PASS: TestAccAppStreamImageBuilder_complete (1792.92s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  1795.935s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.