r/aws_ec2_network_insights_path: Avoid recreating resource when passing an ARN as source or destination

[ewbankkit]

Description

Various aws_ec2_network_insights_path fixes.

Relations

Closes #31123.
Closes #28683.
Closes #28330.
Relates #32658.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPath_' PKG=ec2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInsightsPath_ -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== RUN   TestAccVPCNetworkInsightsPath_disappears
=== PAUSE TestAccVPCNetworkInsightsPath_disappears
=== RUN   TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN   TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== PAUSE TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== RUN   TestAccVPCNetworkInsightsPath_sourceIP
=== PAUSE TestAccVPCNetworkInsightsPath_sourceIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationIP
=== PAUSE TestAccVPCNetworkInsightsPath_destinationIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationPort
=== PAUSE TestAccVPCNetworkInsightsPath_destinationPort
=== CONT  TestAccVPCNetworkInsightsPath_basic
=== CONT  TestAccVPCNetworkInsightsPath_sourceIP
--- PASS: TestAccVPCNetworkInsightsPath_basic (57.25s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationPort
--- PASS: TestAccVPCNetworkInsightsPath_sourceIP (88.68s)
=== CONT  TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCNetworkInsightsPath_destinationPort (86.46s)
=== CONT  TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
--- PASS: TestAccVPCNetworkInsightsPath_sourceAndDestinationARN (53.52s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationIP
--- PASS: TestAccVPCNetworkInsightsPath_tags (122.06s)
=== CONT  TestAccVPCNetworkInsightsPath_disappears
--- PASS: TestAccVPCNetworkInsightsPath_disappears (59.85s)
--- PASS: TestAccVPCNetworkInsightsPath_destinationIP (86.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	290.139s

% make testacc TESTARGS='-run=TestAccVPCNetworkInsightsPathDataSource_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCNetworkInsightsPathDataSource_basic -timeout 180m
=== RUN   TestAccVPCNetworkInsightsPathDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsPathDataSource_basic
=== CONT  TestAccVPCNetworkInsightsPathDataSource_basic
--- PASS: TestAccVPCNetworkInsightsPathDataSource_basic (46.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.380s

% make testacc TESTARGS='-run=TestAccVPCNetworkInsightsAnalysis_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCNetworkInsightsAnalysis_ -timeout 180m
=== RUN   TestAccVPCNetworkInsightsAnalysis_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysis_basic
=== RUN   TestAccVPCNetworkInsightsAnalysis_disappears
=== PAUSE TestAccVPCNetworkInsightsAnalysis_disappears
=== RUN   TestAccVPCNetworkInsightsAnalysis_tags
=== PAUSE TestAccVPCNetworkInsightsAnalysis_tags
=== RUN   TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== PAUSE TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== RUN   TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== PAUSE TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== CONT  TestAccVPCNetworkInsightsAnalysis_basic
=== CONT  TestAccVPCNetworkInsightsAnalysis_filterInARNs
--- PASS: TestAccVPCNetworkInsightsAnalysis_basic (86.25s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_waitForCompletion
--- PASS: TestAccVPCNetworkInsightsAnalysis_filterInARNs (158.55s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_tags
--- PASS: TestAccVPCNetworkInsightsAnalysis_waitForCompletion (85.52s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_disappears
--- PASS: TestAccVPCNetworkInsightsAnalysis_disappears (73.56s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_tags (154.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	319.752s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.