Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix r/aws_fsx_ontap_file_system - increase max iops #33263

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix r/aws_fsx_ontap_file_system - increase max iops #33263

merged 2 commits into from
Sep 1, 2023

Conversation

coreylane
Copy link
Contributor

Description

Changes maximum disk_iops_configuration.iops allowed in r/aws_fsx_ontap_file_system to 160000

Relations

Closes #33257

References

https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-fsx-netapp-ontap-doubles-maximum-throughput-capacity-ssd-iops-file-system/

Output from Acceptance Testing

make testacc TESTS=TestAccFSxOntapFileSystem_basic PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run='TestAccFSxOntapFileSystem_basic'  -timeout 180m
=== RUN   TestAccFSxOntapFileSystem_basic
=== PAUSE TestAccFSxOntapFileSystem_basic
=== CONT  TestAccFSxOntapFileSystem_basic
--- PASS: TestAccFSxOntapFileSystem_basic (2305.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        2309.229s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. labels Aug 31, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2023
@coreylane coreylane changed the title increase max iops fix r/aws_fsx_ontap_file_system - increase max iops Aug 31, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 1, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@coreylane Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 770c4d2 into hashicorp:main Sep 1, 2023
@github-actions github-actions bot added this to the v5.16.0 milestone Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This functionality has been released in v5.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: r/aws_fsx_ontap_file_system has outdated max iops validation
3 participants