-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F add json attribute to patch baseline resource #33402
F add json attribute to patch baseline resource #33402
Conversation
Community NoteVoting for Prioritization
For Submitters
|
8487bdc
to
557650a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t T='TestAccSSMPatchBaselineDataSource_|TestAccSSMPatchBaseline_' K=ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaselineDataSource_|TestAccSSMPatchBaseline_' -timeout 360m
=== RUN TestAccSSMPatchBaselineDataSource_existingBaseline
=== PAUSE TestAccSSMPatchBaselineDataSource_existingBaseline
=== RUN TestAccSSMPatchBaselineDataSource_newBaseline
=== PAUSE TestAccSSMPatchBaselineDataSource_newBaseline
=== RUN TestAccSSMPatchBaseline_basic
=== PAUSE TestAccSSMPatchBaseline_basic
=== RUN TestAccSSMPatchBaseline_tags
=== PAUSE TestAccSSMPatchBaseline_tags
=== RUN TestAccSSMPatchBaseline_disappears
=== PAUSE TestAccSSMPatchBaseline_disappears
=== RUN TestAccSSMPatchBaseline_operatingSystem
=== PAUSE TestAccSSMPatchBaseline_operatingSystem
=== RUN TestAccSSMPatchBaseline_approveUntilDateParam
=== PAUSE TestAccSSMPatchBaseline_approveUntilDateParam
=== RUN TestAccSSMPatchBaseline_sources
=== PAUSE TestAccSSMPatchBaseline_sources
=== RUN TestAccSSMPatchBaseline_approvedPatchesNonSec
=== PAUSE TestAccSSMPatchBaseline_approvedPatchesNonSec
=== RUN TestAccSSMPatchBaseline_rejectPatchesAction
=== PAUSE TestAccSSMPatchBaseline_rejectPatchesAction
=== CONT TestAccSSMPatchBaselineDataSource_existingBaseline
=== CONT TestAccSSMPatchBaseline_operatingSystem
=== CONT TestAccSSMPatchBaseline_tags
=== CONT TestAccSSMPatchBaseline_basic
=== CONT TestAccSSMPatchBaseline_disappears
=== CONT TestAccSSMPatchBaseline_approvedPatchesNonSec
=== CONT TestAccSSMPatchBaseline_approveUntilDateParam
=== CONT TestAccSSMPatchBaseline_rejectPatchesAction
=== CONT TestAccSSMPatchBaselineDataSource_newBaseline
=== CONT TestAccSSMPatchBaseline_sources
--- PASS: TestAccSSMPatchBaselineDataSource_existingBaseline (17.37s)
--- PASS: TestAccSSMPatchBaselineDataSource_newBaseline (24.04s)
--- PASS: TestAccSSMPatchBaseline_disappears (24.62s)
--- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (28.50s)
--- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (28.65s)
--- PASS: TestAccSSMPatchBaseline_sources (41.26s)
--- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (41.39s)
--- PASS: TestAccSSMPatchBaseline_basic (41.53s)
--- PASS: TestAccSSMPatchBaseline_operatingSystem (41.65s)
--- PASS: TestAccSSMPatchBaseline_tags (50.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 52.979s
This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adding the json attribute to the patch_baseline resource. In order to define custom baselines in aws you need to be able to upload the s3 definition of the patchbaseline to an S3 bucket. The json definition facilitates in creating a pattern in terraform to do this.
Closes #33565.
Output from Acceptance Testing