Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 #33416

Merged
merged 33 commits into from
Sep 12, 2023
Merged

Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 #33416

merged 33 commits into from
Sep 12, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 11, 2023 •
edited
Loading

Description

Migrates further s3control resources to AWS SDK for Go v2.

Relations

Closes #30036.
Relates #27097.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPointPolicy_update
--- PASS: TestAccS3ControlAccessPoint_disappears (27.99s)
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
--- PASS: TestAccS3ControlAccessPointPolicy_basic (32.96s)
=== CONT  TestAccS3ControlAccessPoint_vpc
--- PASS: TestAccS3ControlAccessPointPolicy_update (55.13s)
=== CONT  TestAccS3ControlAccessPoint_basic
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (30.33s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
--- PASS: TestAccS3ControlAccessPoint_vpc (29.53s)
=== CONT  TestAccS3ControlAccessPoint_policy
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (26.36s)
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
--- PASS: TestAccS3ControlAccessPoint_basic (29.64s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== NAME  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (0.55s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (27.33s)
--- PASS: TestAccS3ControlAccessPoint_policy (70.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	137.633s
% make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlock_serial' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccountPublicAccessBlock_serial -timeout 180m
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial
=== PAUSE TestAccS3ControlAccountPublicAccessBlock_serial
=== CONT  TestAccS3ControlAccountPublicAccessBlock_serial
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy
--- PASS: TestAccS3ControlAccountPublicAccessBlock_serial (379.37s)
    --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock (379.37s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls (69.80s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets (69.54s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic (24.64s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic (28.09s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears (21.91s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId (28.08s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls (68.75s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy (68.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	384.617s
% make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== RUN   TestAccS3ControlMultiRegionAccessPoint_disappears
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_disappears
=== RUN   TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== RUN   TestAccS3ControlMultiRegionAccessPoint_name
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (299.67s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (349.69s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (428.15s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (269.21s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_threeRegions
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (525.99s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
--- PASS: TestAccS3ControlMultiRegionAccessPoint_name (464.03s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_threeRegions (429.66s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_disappears
--- PASS: TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock (255.27s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (260.83s)
--- PASS: TestAccS3ControlMultiRegionAccessPoint_disappears (241.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	1295.205s
% AWS_DEFAULT_REGION=eu-west-1 make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== RUN   TestAccS3ControlMultiRegionAccessPoint_disappears
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_disappears
=== RUN   TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== RUN   TestAccS3ControlMultiRegionAccessPoint_name
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (249.68s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (323.04s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_name
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (358.28s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_threeRegions
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (260.10s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_threeRegions (443.78s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_name
--- PASS: TestAccS3ControlMultiRegionAccessPoint_name (487.43s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (317.53s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_disappears
--- PASS: TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock (237.08s)
--- PASS: TestAccS3ControlMultiRegionAccessPoint_disappears (243.96s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (529.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	1336.613s
% make testacc TESTARGS='-run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_ -timeout 180m
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_basic
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_basic
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_disappears
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_disappears
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker
    acctest.go:85: S3 on Outposts does not error or save it in the API when receiving this parameter
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker (0.00s)
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== RUN   TestAccS3ControlBucketPolicy_basic
=== PAUSE TestAccS3ControlBucketPolicy_basic
=== RUN   TestAccS3ControlBucketPolicy_disappears
=== PAUSE TestAccS3ControlBucketPolicy_disappears
=== RUN   TestAccS3ControlBucketPolicy_policy
=== PAUSE TestAccS3ControlBucketPolicy_policy
=== RUN   TestAccS3ControlBucket_basic
=== PAUSE TestAccS3ControlBucket_basic
=== RUN   TestAccS3ControlBucket_disappears
=== PAUSE TestAccS3ControlBucket_disappears
=== RUN   TestAccS3ControlBucket_tags
    acctest.go:85: S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: https://github.com/hashicorp/terraform-provider-aws/issues/15572
--- SKIP: TestAccS3ControlBucket_tags (0.00s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_basic
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== CONT  TestAccS3ControlBucketPolicy_policy
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_policy (1.04s)
=== CONT  TestAccS3ControlBucketPolicy_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_id (1.06s)
=== CONT  TestAccS3ControlBucketPolicy_basic
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_basic (1.14s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== NAME  TestAccS3ControlBucketPolicy_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_basic (0.19s)
=== CONT  TestAccS3ControlBucket_basic
=== NAME  TestAccS3ControlBucketPolicy_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_disappears (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_status (0.20s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== NAME  TestAccS3ControlBucket_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_basic (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days (0.21s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation (0.22s)
=== CONT  TestAccS3ControlBucket_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date (0.21s)
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_disappears (0.20s)
=== NAME  TestAccS3ControlBucket_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_disappears (0.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	7.242s
% make testacc TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlObjectLambdaAccessPointPolicy_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlObjectLambdaAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_update
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_basic (54.02s)
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (62.91s)
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (73.37s)
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_update
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint (42.55s)
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_disappears
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (42.74s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_disappears (42.19s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_update (70.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	149.145s
% make testacc TESTARGS='-run=TestAccS3ControlStorageLensConfiguration_' PKG=s3control ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 2  -run=TestAccS3ControlStorageLensConfiguration_ -timeout 180m
=== RUN   TestAccS3ControlStorageLensConfiguration_basic
=== PAUSE TestAccS3ControlStorageLensConfiguration_basic
=== RUN   TestAccS3ControlStorageLensConfiguration_disappears
=== PAUSE TestAccS3ControlStorageLensConfiguration_disappears
=== RUN   TestAccS3ControlStorageLensConfiguration_tags
=== PAUSE TestAccS3ControlStorageLensConfiguration_tags
=== RUN   TestAccS3ControlStorageLensConfiguration_update
=== PAUSE TestAccS3ControlStorageLensConfiguration_update
=== RUN   TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== PAUSE TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== CONT  TestAccS3ControlStorageLensConfiguration_basic
=== CONT  TestAccS3ControlStorageLensConfiguration_update
--- PASS: TestAccS3ControlStorageLensConfiguration_basic (24.01s)
=== CONT  TestAccS3ControlStorageLensConfiguration_tags
--- PASS: TestAccS3ControlStorageLensConfiguration_update (50.70s)
=== CONT  TestAccS3ControlStorageLensConfiguration_disappears
--- PASS: TestAccS3ControlStorageLensConfiguration_disappears (17.65s)
=== CONT  TestAccS3ControlStorageLensConfiguration_advancedMetrics
--- PASS: TestAccS3ControlStorageLensConfiguration_tags (58.32s)
--- PASS: TestAccS3ControlStorageLensConfiguration_advancedMetrics (38.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	111.576s
% make sweep SWEEPARGS=-sweep-run=aws_s3control_storage_lens_configuration,aws_s3control_multi_region_access_point,aws_s3_access_point
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2,us-west-1 -sweep-run=aws_s3control_storage_lens_configuration,aws_s3control_multi_region_access_point,aws_s3_access_point -timeout 60m
2023/09/12 10:18:24 [DEBUG] Running Sweepers for region (us-west-2):
2023/09/12 10:18:24 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-west-2)
2023/09/12 10:18:25 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-west-2) in 930.345446ms
2023/09/12 10:18:25 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 10:18:25 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2)
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2) in 131.05113ms
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-west-2)
2023/09/12 10:18:26 [DEBUG] Waiting for state to become: [success]
2023/09/12 10:18:26 [DEBUG] Deleting S3 Access Point: 187416307283:tf-acc-test-1592931531372902498
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-west-2) in 207.858109ms
2023/09/12 10:18:26 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-2)
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3control_storage_lens_configuration) in region (us-west-2)
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3control_storage_lens_configuration) in region (us-west-2) in 106.150529ms
2023/09/12 10:18:26 Completed Sweepers for region (us-west-2) in 1.37581324s
2023/09/12 10:18:26 Sweeper Tests for region (us-west-2) ran successfully:
2023/09/12 10:18:26 	- aws_s3control_multi_region_access_point
2023/09/12 10:18:26 	- aws_s3control_object_lambda_access_point
2023/09/12 10:18:26 	- aws_s3_access_point
2023/09/12 10:18:26 	- aws_s3control_storage_lens_configuration
2023/09/12 10:18:26 [DEBUG] Running Sweepers for region (us-east-1):
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3control_storage_lens_configuration) in region (us-east-1)
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3control_storage_lens_configuration) in region (us-east-1) in 369.095041ms
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-east-1)
2023/09/12 10:18:26 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-east-1
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-east-1) in 23.37µs
2023/09/12 10:18:26 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1)
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1) in 67.10792ms
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-east-1)
2023/09/12 10:18:26 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-east-1) in 34.372243ms
2023/09/12 10:18:26 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-1)
2023/09/12 10:18:26 Completed Sweepers for region (us-east-1) in 470.780112ms
2023/09/12 10:18:26 Sweeper Tests for region (us-east-1) ran successfully:
2023/09/12 10:18:26 	- aws_s3control_storage_lens_configuration
2023/09/12 10:18:26 	- aws_s3control_multi_region_access_point
2023/09/12 10:18:26 	- aws_s3control_object_lambda_access_point
2023/09/12 10:18:26 	- aws_s3_access_point
2023/09/12 10:18:26 [DEBUG] Running Sweepers for region (us-east-2):
2023/09/12 10:18:26 [DEBUG] Running Sweeper (aws_s3control_storage_lens_configuration) in region (us-east-2)
2023/09/12 10:18:27 [DEBUG] Completed Sweeper (aws_s3control_storage_lens_configuration) in region (us-east-2) in 457.470939ms
2023/09/12 10:18:27 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-east-2)
2023/09/12 10:18:27 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-east-2
2023/09/12 10:18:27 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-east-2) in 8.41µs
2023/09/12 10:18:27 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 10:18:27 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2)
2023/09/12 10:18:27 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2) in 78.27933ms
2023/09/12 10:18:27 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-east-2)
2023/09/12 10:18:27 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-east-2) in 46.380217ms
2023/09/12 10:18:27 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-east-2)
2023/09/12 10:18:27 Completed Sweepers for region (us-east-2) in 582.325784ms
2023/09/12 10:18:27 Sweeper Tests for region (us-east-2) ran successfully:
2023/09/12 10:18:27 	- aws_s3control_storage_lens_configuration
2023/09/12 10:18:27 	- aws_s3control_multi_region_access_point
2023/09/12 10:18:27 	- aws_s3control_object_lambda_access_point
2023/09/12 10:18:27 	- aws_s3_access_point
2023/09/12 10:18:27 [DEBUG] Running Sweepers for region (us-west-1):
2023/09/12 10:18:27 [DEBUG] Sweeper (aws_s3_access_point) has dependency (aws_s3control_object_lambda_access_point), running..
2023/09/12 10:18:27 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1)
2023/09/12 10:18:28 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1) in 994.27761ms
2023/09/12 10:18:28 [DEBUG] Running Sweeper (aws_s3_access_point) in region (us-west-1)
2023/09/12 10:18:28 [DEBUG] Completed Sweeper (aws_s3_access_point) in region (us-west-1) in 101.653399ms
2023/09/12 10:18:28 [DEBUG] Sweeper (aws_s3control_object_lambda_access_point) already ran in region (us-west-1)
2023/09/12 10:18:28 [DEBUG] Running Sweeper (aws_s3control_storage_lens_configuration) in region (us-west-1)
2023/09/12 10:18:28 [DEBUG] Completed Sweeper (aws_s3control_storage_lens_configuration) in region (us-west-1) in 99.818851ms
2023/09/12 10:18:28 [DEBUG] Running Sweeper (aws_s3control_multi_region_access_point) in region (us-west-1)
2023/09/12 10:18:28 [WARN] Skipping S3 Multi-Region Access Point sweep for region: us-west-1
2023/09/12 10:18:28 [DEBUG] Completed Sweeper (aws_s3control_multi_region_access_point) in region (us-west-1) in 8.354µs
2023/09/12 10:18:28 Completed Sweepers for region (us-west-1) in 1.195963226s
2023/09/12 10:18:28 Sweeper Tests for region (us-west-1) ran successfully:
2023/09/12 10:18:28 	- aws_s3_access_point
2023/09/12 10:18:28 	- aws_s3control_storage_lens_configuration
2023/09/12 10:18:28 	- aws_s3control_multi_region_access_point
2023/09/12 10:18:28 	- aws_s3control_object_lambda_access_point
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	8.621s

@ewbankkit
r/aws_s3_access_point(_policy): Migrate to AWS SDK for Go v2.
6da9a69
@ewbankkit
(d|r)/aws_s3_account_public_access_block: Migrate to AWS SDK for Go v2.
d912890
@ewbankkit
r/aws_s3control_multi_region_access_point(_policy): Migrate to AWS SD…
2e1703d 
…K for Go v2.
@ewbankkit
Remove 'connForMRAP'.
c24e039
@ewbankkit
Add 'names.S3ControlEndpointID'.
2f9860e
@ewbankkit
r/aws_s3control_storage_lens_configuration: Use 'names.S3ControlEndpo…
2598d82 
…intID' in acceptance tests.
@ewbankkit
Move AsyncOperation.RequestStatus constants.
be33f6a
@ewbankkit
s3control: Migrate Access Point, Account Public Access Block and MRAP…
cebbaae 
… acceptance tests to AWS SDK for Go v2.
@ewbankkit
Acceptance test output:
a0eef42 
% make testacc TESTARGS='-run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlAccessPointPolicy_\|TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPointPolicy_update
--- PASS: TestAccS3ControlAccessPoint_disappears (27.99s)
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
--- PASS: TestAccS3ControlAccessPointPolicy_basic (32.96s)
=== CONT  TestAccS3ControlAccessPoint_vpc
--- PASS: TestAccS3ControlAccessPointPolicy_update (55.13s)
=== CONT  TestAccS3ControlAccessPoint_basic
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (30.33s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
--- PASS: TestAccS3ControlAccessPoint_vpc (29.53s)
=== CONT  TestAccS3ControlAccessPoint_policy
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (26.36s)
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
--- PASS: TestAccS3ControlAccessPoint_basic (29.64s)
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== NAME  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (0.55s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (27.33s)
--- PASS: TestAccS3ControlAccessPoint_policy (70.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	137.633s
@ewbankkit
Acceptance test output:
eef4563 
% make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlMultiRegionAccessPointDataSource_\|TestAccS3ControlMultiRegionAccessPointPolicy_\|TestAccS3ControlMultiRegionAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== RUN   TestAccS3ControlMultiRegionAccessPoint_disappears
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_disappears
=== RUN   TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
=== RUN   TestAccS3ControlMultiRegionAccessPoint_name
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_name
=== RUN   TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_threeRegions
=== CONT  TestAccS3ControlMultiRegionAccessPointDataSource_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (299.67s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (349.69s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
--- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (428.15s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_name
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (269.21s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_threeRegions
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (525.99s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock
--- PASS: TestAccS3ControlMultiRegionAccessPoint_name (464.03s)
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_threeRegions (429.66s)
=== CONT  TestAccS3ControlMultiRegionAccessPoint_disappears
--- PASS: TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock (255.27s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (260.83s)
--- PASS: TestAccS3ControlMultiRegionAccessPoint_disappears (241.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	1295.205s
@ewbankkit
Revert "(d|r)/aws_s3_account_public_access_block: Migrate to AWS SDK …
81c02ac 
…for Go v2."

This reverts commit d912890.
@ewbankkit
Acceptance test output:
6e526d1 
% make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlock_serial' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlAccountPublicAccessBlock_serial -timeout 180m
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial
=== PAUSE TestAccS3ControlAccountPublicAccessBlock_serial
=== CONT  TestAccS3ControlAccountPublicAccessBlock_serial
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls
=== RUN   TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy
--- PASS: TestAccS3ControlAccountPublicAccessBlock_serial (379.37s)
    --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock (379.37s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls (69.80s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets (69.54s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic (24.64s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic (28.09s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears (21.91s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId (28.08s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls (68.75s)
        --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy (68.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	384.617s
@ewbankkit
Fix typos.
129c051
@ewbankkit
s3control: Generate AWS SDK for Go v2 tagging code.
d0dd209
@ewbankkit
Merge 'RetryWhenAWSErrCodeEqualsV2' into 'RetryWhenAWSErrCodeEquals'.
120dff9
@ewbankkit
Merge 'RetryWhenAWSErrMessageContainsV2' into 'RetryWhenAWSErrMessage…
56f3ad5 
…Contains'.
@ewbankkit
r/aws_s3control_bucket(_lifecycle_configuration|_policy): Migrate to …
968dbfc 
…AWS SDK for Go v2.
@ewbankkit
r/aws_s3control_bucket(_lifecycle_configuration|_policy): Migrate acc…
661aaaf 
…eptance tests to AWS SDK for Go v2.
@ewbankkit
Acceptance test output:
9244740 
% make testacc TESTARGS='-run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlBucketLifecycleConfiguration_\|TestAccS3ControlBucketPolicy_\|TestAccS3ControlBucket_ -timeout 180m
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_basic
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_basic
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_disappears
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_disappears
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker
    acctest.go:85: S3 on Outposts does not error or save it in the API when receiving this parameter
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker (0.00s)
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== RUN   TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== RUN   TestAccS3ControlBucketPolicy_basic
=== PAUSE TestAccS3ControlBucketPolicy_basic
=== RUN   TestAccS3ControlBucketPolicy_disappears
=== PAUSE TestAccS3ControlBucketPolicy_disappears
=== RUN   TestAccS3ControlBucketPolicy_policy
=== PAUSE TestAccS3ControlBucketPolicy_policy
=== RUN   TestAccS3ControlBucket_basic
=== PAUSE TestAccS3ControlBucket_basic
=== RUN   TestAccS3ControlBucket_disappears
=== PAUSE TestAccS3ControlBucket_disappears
=== RUN   TestAccS3ControlBucket_tags
    acctest.go:85: S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: #15572
--- SKIP: TestAccS3ControlBucket_tags (0.00s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_basic
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
=== CONT  TestAccS3ControlBucketPolicy_policy
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_policy (1.04s)
=== CONT  TestAccS3ControlBucketPolicy_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_id
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_id (1.06s)
=== CONT  TestAccS3ControlBucketPolicy_basic
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_basic (1.14s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
=== NAME  TestAccS3ControlBucketPolicy_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_basic (0.19s)
=== CONT  TestAccS3ControlBucket_basic
=== NAME  TestAccS3ControlBucketPolicy_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_disappears (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_Rule_status
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_status (0.20s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
=== NAME  TestAccS3ControlBucket_basic
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_basic (0.22s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days (0.21s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix (0.19s)
=== CONT  TestAccS3ControlBucketLifecycleConfiguration_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation (0.22s)
=== CONT  TestAccS3ControlBucket_disappears
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date (0.21s)
=== NAME  TestAccS3ControlBucketLifecycleConfiguration_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketLifecycleConfiguration_disappears (0.20s)
=== NAME  TestAccS3ControlBucket_disappears
    acctest.go:1102: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucket_disappears (0.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	7.242s
@ewbankkit
Merge branch 'main' into td-migrate-s3control-to-aws-sdk-v2
056b9c7
@ewbankkit
r/aws_s3control_object_lambda_access_point: Migrate to AWS SDK for Go…
c1d5f8b 
… v2.
@ewbankkit
r/aws_s3control_object_lambda_access_point: Migrate acceptance tests …
7f6f479 
…to AWS SDK for Go v2.
@ewbankkit
r/aws_s3control_object_lambda_access_point_policy: Migrate to AWS SDK…
43b93f7 
… for Go v2.
@ewbankkit
r/aws_s3control_object_lambda_access_point_policy: Migrate acceptance…
619b33f 
… tests to AWS SDK for Go v2.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3control Issues and PRs that pertain to the s3control service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. and removed size/XL Managed by automation to categorize the size of a PR. labels Sep 11, 2023
@github-actions github-actions bot added tags Pertains to resource tagging. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. labels Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Sep 11, 2023
@ewbankkit
Copy link
Contributor Author

Migration of aws_s3_account_public_access_block requires resolution of aws/aws-sdk-go-v2#2162.

@ewbankkit
Start to add AWS partition and region IDs to 'names'.
0cfcbf8
@ewbankkit
Use 'names.USWest2RegionID'.
a9a9904
@ewbankkit
Use 'names.USGovCloudPartitionID'.
5b2709c
@ewbankkit
s3control: Add and use 'errCodeNoSuchConfiguration'.
2886253
@ewbankkit
r/aws_s3control_storage_lens_configuration: Use 'tfawserr.ErrHTTPStat…
84c24ab 
…usCodeEquals'.
@ewbankkit
Acceptance test output:
7b805c5 
% make testacc TESTARGS='-run=TestAccS3ControlStorageLensConfiguration_' PKG=s3control ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 2  -run=TestAccS3ControlStorageLensConfiguration_ -timeout 180m
=== RUN   TestAccS3ControlStorageLensConfiguration_basic
=== PAUSE TestAccS3ControlStorageLensConfiguration_basic
=== RUN   TestAccS3ControlStorageLensConfiguration_disappears
=== PAUSE TestAccS3ControlStorageLensConfiguration_disappears
=== RUN   TestAccS3ControlStorageLensConfiguration_tags
=== PAUSE TestAccS3ControlStorageLensConfiguration_tags
=== RUN   TestAccS3ControlStorageLensConfiguration_update
=== PAUSE TestAccS3ControlStorageLensConfiguration_update
=== RUN   TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== PAUSE TestAccS3ControlStorageLensConfiguration_advancedMetrics
=== CONT  TestAccS3ControlStorageLensConfiguration_basic
=== CONT  TestAccS3ControlStorageLensConfiguration_update
--- PASS: TestAccS3ControlStorageLensConfiguration_basic (24.01s)
=== CONT  TestAccS3ControlStorageLensConfiguration_tags
--- PASS: TestAccS3ControlStorageLensConfiguration_update (50.70s)
=== CONT  TestAccS3ControlStorageLensConfiguration_disappears
--- PASS: TestAccS3ControlStorageLensConfiguration_disappears (17.65s)
=== CONT  TestAccS3ControlStorageLensConfiguration_advancedMetrics
--- PASS: TestAccS3ControlStorageLensConfiguration_tags (58.32s)
--- PASS: TestAccS3ControlStorageLensConfiguration_advancedMetrics (38.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	111.576s
@ewbankkit
s3control: Migrate sweepers to AWS SDK for Go v2.
553d913
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Sep 12, 2023
@ewbankkit ewbankkit changed the title [WIP] Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 Tech debt: Migrate (more) s3control resources to AWS SDK for Go v2 Sep 12, 2023
@ewbankkit
r/aws_s3control_multi_region_access_point: Add 'details.region.bucket…
54a8645 
…_account_id' argument.
@ewbankkit
Acceptance test output:
86f2350 
% make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPoint_basic' PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20  -run=TestAccS3ControlMultiRegionAccessPoint_basic -timeout 180m
=== RUN   TestAccS3ControlMultiRegionAccessPoint_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPoint_basic
--- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (297.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	303.040s
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Sep 12, 2023
@ewbankkit ewbankkit merged commit 8642fe9 into main Sep 12, 2023
51 checks passed
@ewbankkit ewbankkit deleted the td-migrate-s3control-to-aws-sdk-v2 branch September 12, 2023 18:40
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 12, 2023
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
Update CHANGELOG.md for #33416
cd2c2fb
@github-actions
Copy link

This functionality has been released in v5.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Sep 27, 2023
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/s3control Issues and PRs that pertain to the s3control service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.17.0
Development

Successfully merging this pull request may close these issues.

Cross-account Amazon S3 Multi-Region Access Points
2 participants
@ewbankkit @justinretzolk