[enhancement]: r/aws_lightsail_bucket: add force_delete attr for lightsail s3 bucket

[k4rtikp4til]

Description

adds force_delete attribute to Lightsail Bucket which allows to force delete a non-empty bucket during terraform destroy

I have amended the testAccLightsailBucket_basic to check for default force_delete value and added testAccLightsailBucket_forceDelete to check for force_delete=true. Happy to amend/add more acceptance tests if required.

Relations

Closes #33585

References

AWS Go SDK: https://docs.aws.amazon.com/sdk-for-go/api/service/lightsail/#Lightsail.DeleteBucket

Output from Acceptance Testing

TestAccLightsailBucket_basic

% make testacc TESTS=TestAccLightsailBucket_basic PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailBucket_basic'  -timeout 360m
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailBucket_basic (40.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  42.477s
...

TestAccLightsailBucket_forceDelete

% make testacc TESTS=TestAccLightsailBucket_basic PKG=lightsail

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailBucket_forceDelete'  -timeout 360m
=== RUN   TestAccLightsailBucket_forceDelete
=== PAUSE TestAccLightsailBucket_forceDelete
=== CONT  TestAccLightsailBucket_forceDelete
--- PASS: TestAccLightsailBucket_forceDelete (40.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  42.063s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailBucket_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailBucket_ -timeout 360m
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailBucket_BundleId
=== PAUSE TestAccLightsailBucket_BundleId
=== RUN   TestAccLightsailBucket_disappears
=== PAUSE TestAccLightsailBucket_disappears
=== RUN   TestAccLightsailBucket_tags
=== PAUSE TestAccLightsailBucket_tags
=== RUN   TestAccLightsailBucket_forceDelete
=== PAUSE TestAccLightsailBucket_forceDelete
=== CONT  TestAccLightsailBucket_basic
=== CONT  TestAccLightsailBucket_tags
--- PASS: TestAccLightsailBucket_basic (41.34s)
=== CONT  TestAccLightsailBucket_disappears
--- PASS: TestAccLightsailBucket_disappears (33.31s)
=== CONT  TestAccLightsailBucket_forceDelete
--- PASS: TestAccLightsailBucket_tags (76.71s)
=== CONT  TestAccLightsailBucket_BundleId
--- PASS: TestAccLightsailBucket_forceDelete (47.65s)
--- PASS: TestAccLightsailBucket_BundleId (75.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	157.024s

[ewbankkit]

@k4rtikp4til Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.