Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_servicequotas_template_association #33725

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 2, 2023

Description

The aws_servicequotas_template_association resource allows a management organization to associate (activate) a quota increases template to be applied across new member accounts.

Relations

Relates #9119

References

Output from Acceptance Testing

% make testacc PKG=servicequotas TESTS=TestAccServiceQuotas_serial/TemplateAssociation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20 -run='TestAccServiceQuotas_serial/TemplateAssociation'  -timeout 360m

--- PASS: TestAccServiceQuotas_serial (51.38s)
    --- PASS: TestAccServiceQuotas_serial/TemplateAssociation (51.37s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/skipDestroy (28.12s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/basic (12.29s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/disappears (10.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      54.517s

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/servicequotas Issues and PRs that pertain to the servicequotas service. generators Relates to code generators. and removed size/XL Managed by automation to categorize the size of a PR. labels Oct 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 2, 2023
@jar-b jar-b marked this pull request as ready for review October 2, 2023 23:04
@jar-b jar-b force-pushed the f-servicequota-template-association branch from e1a7b70 to 7a51a2e Compare October 4, 2023 04:15
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccServiceQuotas_serial/TemplateAssociation' PKG=servicequotas
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicequotas/... -v -count 1 -parallel 20  -run=TestAccServiceQuotas_serial/TemplateAssociation -timeout 360m
=== RUN   TestAccServiceQuotas_serial
=== PAUSE TestAccServiceQuotas_serial
=== CONT  TestAccServiceQuotas_serial
=== RUN   TestAccServiceQuotas_serial/TemplateAssociation
=== RUN   TestAccServiceQuotas_serial/TemplateAssociation/basic
=== RUN   TestAccServiceQuotas_serial/TemplateAssociation/disappears
=== RUN   TestAccServiceQuotas_serial/TemplateAssociation/skipDestroy
--- PASS: TestAccServiceQuotas_serial (104.65s)
    --- PASS: TestAccServiceQuotas_serial/TemplateAssociation (104.65s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/basic (25.69s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/disappears (22.45s)
        --- PASS: TestAccServiceQuotas_serial/TemplateAssociation/skipDestroy (56.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas	110.376s

@jar-b jar-b merged commit 844e710 into main Oct 10, 2023
43 checks passed
@jar-b jar-b deleted the f-servicequota-template-association branch October 10, 2023 13:20
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 10, 2023
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/servicequotas Issues and PRs that pertain to the servicequotas service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants