Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source]: aws_rds_cluster_parameter_group and aws_db_parameter_group #33761

Closed
nwsparks opened this issue Oct 4, 2023 · 7 comments · Fixed by #38416
Closed

[New Data Source]: aws_rds_cluster_parameter_group and aws_db_parameter_group #33761

nwsparks opened this issue Oct 4, 2023 · 7 comments · Fixed by #38416
Labels
new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@nwsparks
Copy link
Contributor

nwsparks commented Oct 4, 2023

Description

A data source for parameter groups would be helpful. One specific use case is related to this problem #22857 which cannot be solved via Terraform.

With a data source I could compare parameters that are being set to what the defaults are and avoid trying to set them if the value already matches avoiding the persistent diff occurring as a result of the issue linked above.

Requested Resource(s) and/or Data Source(s)

  • aws_rds_cluster_parameter_group
  • aws_db_parameter_group

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Oct 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2023
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 26, 2023
@benjamin-wright
Copy link
Contributor

As of today aws_db_parameter_group exists as a data source, and I've had a go at implementing aws_rds_cluster_parameter_group and would like to contribute it back.

Copy link

github-actions bot commented Aug 6, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.62.0 milestone Aug 6, 2024
@nwsparks
Copy link
Contributor Author

nwsparks commented Aug 6, 2024

@johnsonaj @benjamin-wright the newly added data sources are not doing what was described in this issue and are not helpful. I'm not sure if there is even a point to their existence. they need to return the parameters and values to be useful.

@nwsparks
Copy link
Contributor Author

nwsparks commented Aug 6, 2024

also referenced here #13718 (comment)

if its helpful i can open a new issue to ask for that to be added

Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants