Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_lb support enforce_security_group_inbound_rules_on_private_link_traffic #33766

Closed
evan-cleary opened this issue Oct 4, 2023 · 4 comments · Fixed by #33767
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@evan-cleary
Copy link
Contributor

evan-cleary commented Oct 4, 2023

Description

When AWS introduced Security Group support for network load balancers, they added an additional property to configure whether the inbound rules are enforced for PrivateLink traffic.

This property is currently not exposed via the aws_lb/aws_alb resources, so all network load balancers default to the behavior in which inbound rules ARE enforced.

Affected Resource(s) and/or Data Source(s)

  • aws_alb
  • aws_lb

Potential Terraform Configuration

resource "aws_lb" "nlb_with_sg" {
  name               = "nlb-with-sg"
  load_balancer_type = "network"
  subnets            = [...]
  security_groups    = [aws_security_group.nlb_sg.id]

  enforce_security_group_inbound_rules_on_private_link_traffic = "off"
}

References

Would you like to implement a fix?

Yes

@evan-cleary evan-cleary added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Oct 4, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 26, 2023
@cbllopez
Copy link

cbllopez commented Dec 1, 2023

Is there any consideration to support this feature? We are hitting the same issue with NLBs and Private Links from API gateway.

@github-actions github-actions bot added this to the v5.30.0 milestone Dec 6, 2023
Copy link

github-actions bot commented Dec 7, 2023

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jan 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
3 participants