-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_datasync_task: add task_report_config
argument
#33861
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
This has a dependency of aws-sdk-go v1.45.x so this will have to wait until that dependency is upgraded. Also, if I could get some guidance on tests (if any are needed) that would be greatly appreciated. |
…nfig options" This reverts commit 89036cdadbaef4f9a0b055de46c21481abd3a065.
e2b1fe3
to
11fc6d7
Compare
task_report_config
argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=datasync TESTS=TestAccDataSyncTask_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_' -timeout 360m
--- PASS: TestAccDataSyncTask_basic (2461.91s)
=== CONT TestAccDataSyncTask_DefaultSyncOptions_posixPermissions
--- PASS: TestAccDataSyncTask_taskReportConfig (2770.51s)
=== CONT TestAccDataSyncTask_disappears
--- PASS: TestAccDataSyncTask_schedule (3991.42s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDevices (4023.82s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_uid (4031.54s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (4039.69s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_transferMode (4067.68s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_atimeMtime (4079.51s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_preserveDeletedFiles (4094.35s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_gid (4112.52s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_bytesPerSecond (4116.90s)
--- PASS: TestAccDataSyncTask_excludes (4123.19s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_taskQueueing (4127.10s)
--- PASS: TestAccDataSyncTask_includes (4141.39s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_overwriteMode (4141.99s)
--- PASS: TestAccDataSyncTask_cloudWatchLogGroupARN (4156.98s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_logLevel (4160.76s)
--- PASS: TestAccDataSyncTask_disappears (1607.82s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_verifyMode (4486.71s)
--- PASS: TestAccDataSyncTask_tags (4568.43s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_posixPermissions (2143.15s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_securityDescriptorCopyFlags (5128.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 5131.751s
Thanks for your contribution, @rizkybiz and @bruceharrison1984! 👏 |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR introduces the ability to configure AWS DataSync Task Reports.
Relations
Closes #33551
Output from Acceptance Testing