Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neptune slow query logs cloudwatch export #34053

Conversation

VaismanLior
Copy link
Contributor

@VaismanLior VaismanLior commented Oct 22, 2023

Description

Add the ability to export Neptune slow query logs to CloudWatch.
This can be done using the AWS CLI and Console, but fails validation when you try to set it using the module, which causes drifts.

Relations

Non known relations

References

AWS CLI instructions for setting this log export - https://docs.aws.amazon.com/neptune/latest/userguide/cloudwatch-logs.html#cloudwatch-slow-query-logs-cli

Output from Acceptance Testing

% make testacc TESTS=TestAccNeptuneCluster_updateCloudWatchLogsExports PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run='TestAccNeptuneCluster_updateCloudWatchLogsExports'  -timeout 360m
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (298.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    302.265s
...

VaismanLior and others added 2 commits October 22, 2023 10:49
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/neptune Issues and PRs that pertain to the neptune service. labels Oct 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 22, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @VaismanLior 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 23, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNeptuneCluster_updateCloudWatchLogsExports' PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20  -run=TestAccNeptuneCluster_updateCloudWatchLogsExports -timeout 360m
=== RUN   TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== CONT  TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (268.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	274.344s

@ewbankkit
Copy link
Contributor

@VaismanLior Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 877bb45 into hashicorp:main Oct 23, 2023
39 of 41 checks passed
@github-actions github-actions bot added this to the v5.23.0 milestone Oct 23, 2023
@VaismanLior
Copy link
Contributor Author

VaismanLior commented Oct 23, 2023

@VaismanLior Thanks for the contribution 🎉 👏.

Sure! Thanks for your quick response 👑 @ewbankkit

@VaismanLior VaismanLior deleted the f-neptune-slow-query-logs-cloudwatch-export branch October 23, 2023 12:48
@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants