-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neptune slow query logs cloudwatch export #34053
Neptune slow query logs cloudwatch export #34053
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @VaismanLior 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNeptuneCluster_updateCloudWatchLogsExports' PKG=neptune
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 20 -run=TestAccNeptuneCluster_updateCloudWatchLogsExports -timeout 360m
=== RUN TestAccNeptuneCluster_updateCloudWatchLogsExports
=== PAUSE TestAccNeptuneCluster_updateCloudWatchLogsExports
=== CONT TestAccNeptuneCluster_updateCloudWatchLogsExports
--- PASS: TestAccNeptuneCluster_updateCloudWatchLogsExports (268.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 274.344s
@VaismanLior Thanks for the contribution 🎉 👏. |
Sure! Thanks for your quick response 👑 @ewbankkit |
This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add the ability to export Neptune slow query logs to CloudWatch.
This can be done using the AWS CLI and Console, but fails validation when you try to set it using the module, which causes drifts.
Relations
Non known relations
References
AWS CLI instructions for setting this log export - https://docs.aws.amazon.com/neptune/latest/userguide/cloudwatch-logs.html#cloudwatch-slow-query-logs-cli
Output from Acceptance Testing