Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed diff suppress function on canary schedule expression #34084

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

carcher5432
Copy link
Contributor

Description

Fixes the diff suppress function on the schedule expression for aws_synthetics_canary to cover both "rate(0 minute)" and "rate(0 minutes)" being equivalent to the aws internal representation of "rate(0 hour)". Previously, the function had only suppressed changes if it was "rate(0 minute)".

Relations

References

Output from Acceptance Testing

Change does not affect tests

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/synthetics Issues and PRs that pertain to the synthetics service. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 24, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 24, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@jar-b jar-b self-assigned this Nov 10, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 10, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=synthetics TESTS=TestAccSyntheticsCanary_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_'  -timeout 360m

--- PASS: TestAccSyntheticsCanary_disappears (590.47s)
--- PASS: TestAccSyntheticsCanary_s3 (704.57s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (904.62s)
--- PASS: TestAccSyntheticsCanary_basic (929.99s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (931.49s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (939.72s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (952.73s)
--- PASS: TestAccSyntheticsCanary_tags (1003.79s)
--- PASS: TestAccSyntheticsCanary_runTracing (1069.99s)
--- PASS: TestAccSyntheticsCanary_startCanary (1074.48s)
--- PASS: TestAccSyntheticsCanary_run (1078.09s)
--- PASS: TestAccSyntheticsCanary_vpc (3070.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 3073.647s

@jar-b jar-b merged commit aeb7416 into hashicorp:main Nov 10, 2023
36 checks passed
@jar-b
Copy link
Member

jar-b commented Nov 10, 2023

Thanks for your contribution, @carcher5432! 👍

@github-actions github-actions bot added this to the v5.26.0 milestone Nov 10, 2023
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Nov 16, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/synthetics Issues and PRs that pertain to the synthetics service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants