Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_rds_integration #34179

Closed
jar-b opened this issue Oct 31, 2023 · 12 comments · Fixed by #35199
Closed

[New Resource]: aws_rds_integration #34179

jar-b opened this issue Oct 31, 2023 · 12 comments · Fixed by #35199
Labels
new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@jar-b
Copy link
Member

jar-b commented Oct 31, 2023

Description

This resource would support management of zero-ETL integrations between Amazon Aurora and Amazon Redshift.

Requested Resource(s) and/or Data Source(s)

  • aws_rds_integration

Potential Terraform Configuration

resource "aws_rds_integration" "example" {
  integration_name = "example"
  source_arn       = aws_rds_cluster.example.arn
  target_arn       = aws_redshift_cluster.example.arn
  kms_key_id       = ""
  tags             = {}
}

References

Would you like to implement a fix?

None

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Oct 31, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jar-b jar-b added the new-resource Introduces a new resource. label Oct 31, 2023
@mnfusaro
Copy link

It would be greatly appreciated if you would consider this implementation. Regards.

@showwin
Copy link
Contributor

showwin commented Dec 1, 2023

I'm trying to implement this. So far, I'm about 50% done, but since this is my first contribution, it looks like it'll take about another week. If there's anyone who can implement it faster, they are welcome ✋.

@showwin
Copy link
Contributor

showwin commented Dec 22, 2023

Update:
I almost finished writing the code, but I got stuck writing test code. This is because it's hard to prepare prerequisites of Zero-ETL with Terraform. One of the requirements is to add "authorized principals" and "authorized integration sources" on the target RedShift (ref).
The above document says:

You can configure authorized principals and authorized integration sources from the Resource Policy tab on the Amazon Redshift console or using the Amazon Redshift PutResourcePolicy API operation.

However, the PutResourcePolicy does not have the capability to add those resource policies. The API document of PutResourcePolicy says:

Currently, you can use policies to share snapshots across AWS accounts.

I also confirmed the API can work only for snapshot resources but not the namespace resources to which we want to add resource policy.
I'm currently asking AWS support about the limitation of the PutResourcePolicy API.

@showwin
Copy link
Contributor

showwin commented Jan 9, 2024

PR is ready -- #35199.
Please track this PR for more details.|

@showwin
Copy link
Contributor

showwin commented Jan 9, 2024

Regarding the PutResourcePolicy API issue reported above, I found it could work correctly with Redshift API instead of Redshift-serverless API. So I could write acceptance test cases.
I reported the issue to AWS support.

@MihalisW
Copy link

MihalisW commented May 1, 2024

Can I suggest that the resource's name is aws_zero_etl - it would be good for the resource's name to closely match how it is marketed by AWS.

@pc-js
Copy link

pc-js commented May 20, 2024

Can I suggest that the resource's name is aws_zero_etl - it would be good for the resource's name to closely match how it is marketed by AWS.

yes , aws_zero_etl_integration ?

@prafulauto1
Copy link

what about the filtering rules, are we going to have a separate resource for it

Copy link

github-actions bot commented Aug 2, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.62.0 milestone Aug 2, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants