-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the update of KxCluster databases and code configuration #34220
Support the update of KxCluster databases and code configuration #34220
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @matthiasweaser 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Thanks for your contribution, @matthiasweaser! 👏 |
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request introduces changes that allow users to update KxCluster databases and code configuration without having to destroy and recreate a KxCluster resource.
Testing
For acceptance tests relating to these changes, environment deletion is triggered immediately after cluster deletion since cluster deletion no longer waits for the deletion workflow to complete before being marked as "deleted". We are working on a fix for this but essentially this bug is on our side and non-terraform related other than breaking all our existing cluster acceptance tests.
This results in our acceptance tests successfully updating the cluster resource but failing at the resource cleanup step. All other steps of the tests completed successfully.
Acceptance Tests updated:
Manual testing has been done in place to ensure that the behavior of cluster updates are as desired.
References
API documentation for UpdateKxClusterDatabases: https://docs.aws.amazon.com/cli/latest/reference/finspace/update-kx-cluster-databases.html