Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight: fix window_options.bounds validator #34230

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 2, 2023

Description

The various nested bounds arguments all contained validation functions checking for integer ranges, but were TypeFloat types. Changing the validation function to one which expects float types should resolve static validation failures.

Relations

Closes #33223

References

Output from Acceptance Testing

% make testacc PKG=quicksight TESTS="TestAccQuickSightAnalysis_|TestAccQuickSightDashboard_|TestAccQuickSightTemplate_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightAnalysis_|TestAccQuickSightDashboard_|TestAccQuickSightTemplate_'  -timeout 360m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightTemplate_basic (1130.62s)
--- PASS: TestAccQuickSightTemplate_barChart (1140.09s)
--- PASS: TestAccQuickSightTemplate_disappears (1161.07s)
--- PASS: TestAccQuickSightTemplate_sourceEntity (1183.78s)
--- PASS: TestAccQuickSightAnalysis_forceDelete (1184.10s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (1198.54s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (1203.77s)
--- PASS: TestAccQuickSightAnalysis_Definition_calculatedFields (1203.95s)
--- PASS: TestAccQuickSightAnalysis_basic (1211.27s)
--- PASS: TestAccQuickSightAnalysis_disappears (1211.73s)
--- PASS: TestAccQuickSightDashboard_basic (1211.93s)
--- PASS: TestAccQuickSightDashboard_disappears (1218.40s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (1240.86s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (1242.13s)
--- PASS: TestAccQuickSightTemplate_table (1403.49s)
--- PASS: TestAccQuickSightTemplate_update (1429.50s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (1496.88s)
--- PASS: TestAccQuickSightAnalysis_update (1498.78s)
--- PASS: TestAccQuickSightTemplate_tags (1571.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 1574.349s

Copy link

github-actions bot commented Nov 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/quicksight Issues and PRs that pertain to the quicksight service. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 2, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

The various nested bounds arguments all contained validation functions checking
for integer ranges, but were TypeFloat types. Changing the validation function
to one which expects float types should resolve static validation
failures.
@jar-b jar-b force-pushed the b-quicksight-fix-window-options-schema branch from f0d4007 to ecacd85 Compare November 2, 2023 18:47
@jar-b jar-b merged commit 2bd35d3 into main Nov 2, 2023
34 checks passed
@jar-b jar-b deleted the b-quicksight-fix-window-options-schema branch November 2, 2023 19:26
@github-actions github-actions bot added this to the v5.24.0 milestone Nov 2, 2023
github-actions bot pushed a commit that referenced this pull request Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Quicksight window options bug
2 participants