Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate sns resources to AWS SDK for Go v2 #34252

Merged
merged 28 commits into from
Nov 6, 2023
Merged

Migrate sns resources to AWS SDK for Go v2 #34252

merged 28 commits into from
Nov 6, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 3, 2023 •
edited
Loading

Description

Also adds support for SNS FIFO topic message archiving.

Relations

Closes #34150.

Output from Acceptance Testing

Migration

% make testacc TESTARGS='-run=TestAccSNS' PKG=sns ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 3  -run=TestAccSNS -timeout 360m
=== RUN   TestAccSNSPlatformApplication_GCM_basic
    platform_application_test.go:181: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_GCM_basic (0.00s)
=== RUN   TestAccSNSPlatformApplication_disappears
    platform_application_test.go:226: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_disappears (0.00s)
=== RUN   TestAccSNSPlatformApplication_GCM_allAttributes
    platform_application_test.go:255: Environment variable GCM_API_KEY is not set
--- SKIP: TestAccSNSPlatformApplication_GCM_allAttributes (0.00s)
=== RUN   TestAccSNSPlatformApplication_basic
    platform_application_test.go:97: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basic (0.00s)
=== RUN   TestAccSNSPlatformApplication_basicAttributes
    platform_application_test.go:97: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basicAttributes (0.00s)
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
    platform_application_test.go:97: no SNS Platform Application environment variables found
--- SKIP: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (0.00s)
=== RUN   TestAccSNSSMSPreferences_serial
=== PAUSE TestAccSNSSMSPreferences_serial
=== RUN   TestAccSNSTopicDataProtectionPolicy_basic
=== PAUSE TestAccSNSTopicDataProtectionPolicy_basic
=== RUN   TestAccSNSTopicDataProtectionPolicy_disappears
=== PAUSE TestAccSNSTopicDataProtectionPolicy_disappears
=== RUN   TestAccSNSTopicDataSource_basic
=== PAUSE TestAccSNSTopicDataSource_basic
=== RUN   TestAccSNSTopicPolicy_basic
=== PAUSE TestAccSNSTopicPolicy_basic
=== RUN   TestAccSNSTopicPolicy_updated
=== PAUSE TestAccSNSTopicPolicy_updated
=== RUN   TestAccSNSTopicPolicy_Disappears_topic
=== PAUSE TestAccSNSTopicPolicy_Disappears_topic
=== RUN   TestAccSNSTopicPolicy_disappears
=== PAUSE TestAccSNSTopicPolicy_disappears
=== RUN   TestAccSNSTopicPolicy_ignoreEquivalent
=== PAUSE TestAccSNSTopicPolicy_ignoreEquivalent
=== RUN   TestAccSNSTopicSubscription_basic
=== PAUSE TestAccSNSTopicSubscription_basic
=== RUN   TestAccSNSTopicSubscription_filterPolicy
=== PAUSE TestAccSNSTopicSubscription_filterPolicy
=== RUN   TestAccSNSTopicSubscription_filterPolicyScope
=== PAUSE TestAccSNSTopicSubscription_filterPolicyScope
=== RUN   TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
=== PAUSE TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
=== RUN   TestAccSNSTopicSubscription_deliveryPolicy
=== PAUSE TestAccSNSTopicSubscription_deliveryPolicy
=== RUN   TestAccSNSTopicSubscription_redrivePolicy
=== PAUSE TestAccSNSTopicSubscription_redrivePolicy
=== RUN   TestAccSNSTopicSubscription_rawMessageDelivery
=== PAUSE TestAccSNSTopicSubscription_rawMessageDelivery
=== RUN   TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== RUN   TestAccSNSTopicSubscription_email
=== PAUSE TestAccSNSTopicSubscription_email
=== RUN   TestAccSNSTopicSubscription_firehose
=== PAUSE TestAccSNSTopicSubscription_firehose
=== RUN   TestAccSNSTopicSubscription_disappears
=== PAUSE TestAccSNSTopicSubscription_disappears
=== RUN   TestAccSNSTopicSubscription_Disappears_topic
=== PAUSE TestAccSNSTopicSubscription_Disappears_topic
=== RUN   TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN   TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== RUN   TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN   TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN   TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN   TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN   TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN   TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN   TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN   TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN   TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN   TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN   TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN   TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN   TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN   TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== CONT  TestAccSNSSMSPreferences_serial
=== RUN   TestAccSNSSMSPreferences_serial/almostAll
=== CONT  TestAccSNSTopicSubscription_firehose
=== CONT  TestAccSNSTopic_encryption
=== RUN   TestAccSNSSMSPreferences_serial/defaultSMSType
=== RUN   TestAccSNSSMSPreferences_serial/deliveryRole
--- PASS: TestAccSNSTopic_encryption (45.72s)
=== CONT  TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (3.28s)
=== CONT  TestAccSNSTopic_fifoWithContentBasedDeduplication
--- PASS: TestAccSNSSMSPreferences_serial (66.89s)
    --- PASS: TestAccSNSSMSPreferences_serial/almostAll (24.90s)
    --- PASS: TestAccSNSSMSPreferences_serial/defaultSMSType (20.27s)
    --- PASS: TestAccSNSSMSPreferences_serial/deliveryRole (21.73s)
=== CONT  TestAccSNSTopic_tags
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (44.79s)
=== CONT  TestAccSNSTopic_namePrefix
--- PASS: TestAccSNSTopic_namePrefix (26.09s)
=== CONT  TestAccSNSTopic_name
--- PASS: TestAccSNSTopic_tags (63.33s)
=== CONT  TestAccSNSTopic_disappears
--- PASS: TestAccSNSTopic_name (25.33s)
=== CONT  TestAccSNSTopic_basic
--- PASS: TestAccSNSTopic_disappears (19.39s)
=== CONT  TestAccSNSTopicSubscription_Disappears_topic
--- PASS: TestAccSNSTopic_basic (24.27s)
=== CONT  TestAccSNSTopicSubscription_disappears
--- PASS: TestAccSNSTopicSubscription_firehose (191.41s)
=== CONT  TestAccSNSTopic_deliveryStatus
--- PASS: TestAccSNSTopicSubscription_Disappears_topic (50.26s)
=== CONT  TestAccSNSTopic_NamePrefix_fifoTopic
--- PASS: TestAccSNSTopicSubscription_disappears (50.04s)
=== CONT  TestAccSNSTopic_Name_fifoTopic
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (25.43s)
=== CONT  TestAccSNSTopic_NameGenerated_fifoTopic
--- PASS: TestAccSNSTopic_deliveryStatus (36.81s)
=== CONT  TestAccSNSTopicSubscription_filterPolicy
--- PASS: TestAccSNSTopic_Name_fifoTopic (26.20s)
=== CONT  TestAccSNSTopicSubscription_email
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (25.30s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
--- PASS: TestAccSNSTopicSubscription_email (21.34s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (45.38s)
=== CONT  TestAccSNSTopicSubscription_rawMessageDelivery
--- PASS: TestAccSNSTopicSubscription_filterPolicy (87.27s)
=== CONT  TestAccSNSTopic_policy
--- PASS: TestAccSNSTopic_policy (25.97s)
=== CONT  TestAccSNSTopic_withDeliveryPolicy
--- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (99.45s)
=== CONT  TestAccSNSTopic_withFakeIAMRole
--- PASS: TestAccSNSTopic_withDeliveryPolicy (25.01s)
=== CONT  TestAccSNSTopic_withIAMRole
--- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (86.69s)
=== CONT  TestAccSNSTopicSubscription_redrivePolicy
--- PASS: TestAccSNSTopic_withIAMRole (32.74s)
=== CONT  TestAccSNSTopicPolicy_updated
--- PASS: TestAccSNSTopicPolicy_updated (39.61s)
=== CONT  TestAccSNSTopicSubscription_basic
--- PASS: TestAccSNSTopic_withFakeIAMRole (132.97s)
=== CONT  TestAccSNSTopicPolicy_ignoreEquivalent
--- PASS: TestAccSNSTopicSubscription_basic (53.27s)
=== CONT  TestAccSNSTopicPolicy_disappears
--- PASS: TestAccSNSTopicPolicy_disappears (24.08s)
=== CONT  TestAccSNSTopicSubscription_deliveryPolicy
--- PASS: TestAccSNSTopicPolicy_ignoreEquivalent (33.82s)
=== CONT  TestAccSNSTopicPolicy_Disappears_topic
--- PASS: TestAccSNSTopicSubscription_redrivePolicy (125.47s)
=== CONT  TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
--- PASS: TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet (3.18s)
=== CONT  TestAccSNSTopicSubscription_filterPolicyScope
--- PASS: TestAccSNSTopicPolicy_Disappears_topic (19.11s)
=== CONT  TestAccSNSTopicDataProtectionPolicy_disappears
--- PASS: TestAccSNSTopicDataProtectionPolicy_disappears (20.17s)
=== CONT  TestAccSNSTopicPolicy_basic
--- PASS: TestAccSNSTopicPolicy_basic (26.45s)
=== CONT  TestAccSNSTopicDataSource_basic
--- PASS: TestAccSNSTopicDataSource_basic (24.48s)
=== CONT  TestAccSNSTopicDataProtectionPolicy_basic
--- PASS: TestAccSNSTopicSubscription_deliveryPolicy (93.11s)
--- PASS: TestAccSNSTopicDataProtectionPolicy_basic (25.92s)
--- PASS: TestAccSNSTopicSubscription_filterPolicyScope (216.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        749.846s
% GCM_API_KEY=******** make testacc TESTARGS='-run=TestAccSNSPlatformApplication_' PKG=sns ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 2  -run=TestAccSNSPlatformApplication_ -timeout 360m
=== RUN   TestAccSNSPlatformApplication_GCM_basic
=== PAUSE TestAccSNSPlatformApplication_GCM_basic
=== RUN   TestAccSNSPlatformApplication_disappears
=== PAUSE TestAccSNSPlatformApplication_disappears
=== RUN   TestAccSNSPlatformApplication_GCM_allAttributes
=== PAUSE TestAccSNSPlatformApplication_GCM_allAttributes
=== RUN   TestAccSNSPlatformApplication_basic
=== RUN   TestAccSNSPlatformApplication_basic/GCM
=== PAUSE TestAccSNSPlatformApplication_basic
=== RUN   TestAccSNSPlatformApplication_basicAttributes
=== RUN   TestAccSNSPlatformApplication_basicAttributes/GCM
=== PAUSE TestAccSNSPlatformApplication_basicAttributes
=== RUN   TestAccSNSPlatformApplication_basicApnsWithTokenCredentials
--- PASS: TestAccSNSPlatformApplication_basicApnsWithTokenCredentials (0.00s)
=== CONT  TestAccSNSPlatformApplication_GCM_basic
=== CONT  TestAccSNSPlatformApplication_basic
--- PASS: TestAccSNSPlatformApplication_GCM_basic (23.75s)
=== CONT  TestAccSNSPlatformApplication_basicAttributes
=== RUN   TestAccSNSPlatformApplication_basicAttributes/GCM/success_feedback_sample_rate
--- PASS: TestAccSNSPlatformApplication_basic (26.73s)
    --- PASS: TestAccSNSPlatformApplication_basic/GCM (26.73s)
=== CONT  TestAccSNSPlatformApplication_GCM_allAttributes
--- PASS: TestAccSNSPlatformApplication_basicAttributes (41.83s)
    --- PASS: TestAccSNSPlatformApplication_basicAttributes/GCM/success_feedback_sample_rate (41.83s)
    --- PASS: TestAccSNSPlatformApplication_basicAttributes/GCM (68.56s)
=== CONT  TestAccSNSPlatformApplication_disappears
--- PASS: TestAccSNSPlatformApplication_disappears (19.34s)
--- PASS: TestAccSNSPlatformApplication_GCM_allAttributes (61.82s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        94.448s

Enhancement

% make testacc TESTARGS='-run=TestAccSNSTopic_' PKG=sns 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20  -run=TestAccSNSTopic_ -timeout 360m
=== RUN   TestAccSNSTopic_basic
=== PAUSE TestAccSNSTopic_basic
=== RUN   TestAccSNSTopic_disappears
=== PAUSE TestAccSNSTopic_disappears
=== RUN   TestAccSNSTopic_name
=== PAUSE TestAccSNSTopic_name
=== RUN   TestAccSNSTopic_namePrefix
=== PAUSE TestAccSNSTopic_namePrefix
=== RUN   TestAccSNSTopic_tags
=== PAUSE TestAccSNSTopic_tags
=== RUN   TestAccSNSTopic_policy
=== PAUSE TestAccSNSTopic_policy
=== RUN   TestAccSNSTopic_withIAMRole
=== PAUSE TestAccSNSTopic_withIAMRole
=== RUN   TestAccSNSTopic_withFakeIAMRole
=== PAUSE TestAccSNSTopic_withFakeIAMRole
=== RUN   TestAccSNSTopic_withDeliveryPolicy
=== PAUSE TestAccSNSTopic_withDeliveryPolicy
=== RUN   TestAccSNSTopic_deliveryStatus
=== PAUSE TestAccSNSTopic_deliveryStatus
=== RUN   TestAccSNSTopic_NameGenerated_fifoTopic
=== PAUSE TestAccSNSTopic_NameGenerated_fifoTopic
=== RUN   TestAccSNSTopic_Name_fifoTopic
=== PAUSE TestAccSNSTopic_Name_fifoTopic
=== RUN   TestAccSNSTopic_NamePrefix_fifoTopic
=== PAUSE TestAccSNSTopic_NamePrefix_fifoTopic
=== RUN   TestAccSNSTopic_fifoWithContentBasedDeduplication
=== PAUSE TestAccSNSTopic_fifoWithContentBasedDeduplication
=== RUN   TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== PAUSE TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== RUN   TestAccSNSTopic_fifoWithArchivePolicy
=== PAUSE TestAccSNSTopic_fifoWithArchivePolicy
=== RUN   TestAccSNSTopic_fifoExpectArchivePolicyError
=== PAUSE TestAccSNSTopic_fifoExpectArchivePolicyError
=== RUN   TestAccSNSTopic_encryption
=== PAUSE TestAccSNSTopic_encryption
=== CONT  TestAccSNSTopic_basic
=== CONT  TestAccSNSTopic_deliveryStatus
=== CONT  TestAccSNSTopic_fifoExpectContentBasedDeduplicationError
=== CONT  TestAccSNSTopic_fifoWithContentBasedDeduplication
=== CONT  TestAccSNSTopic_NamePrefix_fifoTopic
=== CONT  TestAccSNSTopic_encryption
=== CONT  TestAccSNSTopic_Name_fifoTopic
=== CONT  TestAccSNSTopic_fifoExpectArchivePolicyError
=== CONT  TestAccSNSTopic_NameGenerated_fifoTopic
=== CONT  TestAccSNSTopic_fifoWithArchivePolicy
=== CONT  TestAccSNSTopic_policy
=== CONT  TestAccSNSTopic_withDeliveryPolicy
=== CONT  TestAccSNSTopic_withFakeIAMRole
=== CONT  TestAccSNSTopic_withIAMRole
=== CONT  TestAccSNSTopic_namePrefix
=== CONT  TestAccSNSTopic_tags
=== CONT  TestAccSNSTopic_name
=== CONT  TestAccSNSTopic_disappears
--- PASS: TestAccSNSTopic_fifoExpectContentBasedDeduplicationError (21.94s)
--- PASS: TestAccSNSTopic_fifoExpectArchivePolicyError (22.29s)
--- PASS: TestAccSNSTopic_disappears (106.47s)
--- PASS: TestAccSNSTopic_namePrefix (143.48s)
--- PASS: TestAccSNSTopic_NameGenerated_fifoTopic (143.48s)
--- PASS: TestAccSNSTopic_name (143.50s)
--- PASS: TestAccSNSTopic_Name_fifoTopic (143.52s)
--- PASS: TestAccSNSTopic_policy (143.55s)
--- PASS: TestAccSNSTopic_NamePrefix_fifoTopic (143.79s)
--- PASS: TestAccSNSTopic_basic (143.86s)
--- PASS: TestAccSNSTopic_withDeliveryPolicy (143.87s)
--- PASS: TestAccSNSTopic_deliveryStatus (145.65s)
--- PASS: TestAccSNSTopic_withIAMRole (146.07s)
--- PASS: TestAccSNSTopic_encryption (172.94s)
--- PASS: TestAccSNSTopic_fifoWithContentBasedDeduplication (173.02s)
--- PASS: TestAccSNSTopic_withFakeIAMRole (173.60s)
--- PASS: TestAccSNSTopic_fifoWithArchivePolicy (60.85s)
--- PASS: TestAccSNSTopic_tags (191.64s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        197.318s
% make testacc TESTARGS='-run=TestAccSNSTopicSubscription_' PKG=sns ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 2  -run=TestAccSNSTopicSubscription_ -timeout 360m
=== RUN   TestAccSNSTopicSubscription_basic
=== PAUSE TestAccSNSTopicSubscription_basic
=== RUN   TestAccSNSTopicSubscription_filterPolicy
=== PAUSE TestAccSNSTopicSubscription_filterPolicy
=== RUN   TestAccSNSTopicSubscription_filterPolicyScope
=== PAUSE TestAccSNSTopicSubscription_filterPolicyScope
=== RUN   TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
=== PAUSE TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
=== RUN   TestAccSNSTopicSubscription_deliveryPolicy
=== PAUSE TestAccSNSTopicSubscription_deliveryPolicy
=== RUN   TestAccSNSTopicSubscription_redrivePolicy
=== PAUSE TestAccSNSTopicSubscription_redrivePolicy
=== RUN   TestAccSNSTopicSubscription_rawMessageDelivery
=== PAUSE TestAccSNSTopicSubscription_rawMessageDelivery
=== RUN   TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== RUN   TestAccSNSTopicSubscription_email
=== PAUSE TestAccSNSTopicSubscription_email
=== RUN   TestAccSNSTopicSubscription_firehose
=== PAUSE TestAccSNSTopicSubscription_firehose
=== RUN   TestAccSNSTopicSubscription_disappears
=== PAUSE TestAccSNSTopicSubscription_disappears
=== RUN   TestAccSNSTopicSubscription_Disappears_topic
=== PAUSE TestAccSNSTopicSubscription_Disappears_topic
=== CONT  TestAccSNSTopicSubscription_basic
=== CONT  TestAccSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccSNSTopicSubscription_basic (105.74s)
=== CONT  TestAccSNSTopicSubscription_deliveryPolicy
--- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (125.34s)
=== CONT  TestAccSNSTopicSubscription_rawMessageDelivery
--- PASS: TestAccSNSTopicSubscription_rawMessageDelivery (123.83s)
=== CONT  TestAccSNSTopicSubscription_redrivePolicy
--- PASS: TestAccSNSTopicSubscription_deliveryPolicy (179.56s)
=== CONT  TestAccSNSTopicSubscription_firehose
--- PASS: TestAccSNSTopicSubscription_redrivePolicy (167.46s)
=== CONT  TestAccSNSTopicSubscription_Disappears_topic
--- PASS: TestAccSNSTopicSubscription_Disappears_topic (50.42s)
=== CONT  TestAccSNSTopicSubscription_disappears
--- PASS: TestAccSNSTopicSubscription_firehose (222.81s)
=== CONT  TestAccSNSTopicSubscription_filterPolicy
--- PASS: TestAccSNSTopicSubscription_disappears (101.86s)
=== CONT  TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet
--- PASS: TestAccSNSTopicSubscription_filterPolicyScope_policyNotSet (2.90s)
=== CONT  TestAccSNSTopicSubscription_email
--- PASS: TestAccSNSTopicSubscription_email (20.64s)
=== CONT  TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
--- PASS: TestAccSNSTopicSubscription_filterPolicy (189.69s)
=== CONT  TestAccSNSTopicSubscription_filterPolicyScope
--- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (107.56s)
--- PASS: TestAccSNSTopicSubscription_filterPolicyScope (352.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        1055.884s

@ewbankkit
Use AWS SDK for Go v2 for sns service.
0d77bd7
@ewbankkit
Add 'names.SNSEndpointID'.
596f141
@ewbankkit
Run 'make gen'.
42b2d2e
@ewbankkit
sns: Generate AWS SDK for Go v2 tagging code.
adb4153
@ewbankkit
Run 'go get github.com/aws/aws-sdk-go-v2/service/sns@v1.25.0 && go mo…
320bdf8 
…d tidy'.
@ewbankkit
r/aws_sns_platform_application: Migrate to AWS SDK for Go v2.
5ac9411
@ewbankkit
r/aws_sns_sms_preferences: Migrate to AWS SDK for Go v2.
b9be46d
@ewbankkit
r/aws_sns_topic_data_protection_policy: Migrate to AWS SDK for Go v2.
01d2bf5
@ewbankkit
d/aws_sns_topic: Migrate to AWS SDK for Go v2.
8e15e76
@ewbankkit
r/aws_sns_topic: Migrate to AWS SDK for Go v2.
70926f4
@ewbankkit
r/aws_sns_topic_policy: Migrate to AWS SDK for Go v2.
d5c192a
@ewbankkit
r/aws_sns_topic_subscription: Migrate to AWS SDK for Go v2.
d0cf5cc
@ewbankkit
sns: Migrate sweepers to AWS SDK for Go v2.
b30e4b6
@ewbankkit
sns: Migrate acceptance tests to AWS SDK for Go v2.
995beb8
@ewbankkit
sns: Lowercase constant names.
efff0d1
@ewbankkit
Run 'make fmt'.
eb98ae3
@ewbankkit
'TopicAttributeNamePolicy' -> 'topicAttributeNamePolicy'.
9271201
@ewbankkit
r/aws_sns_platform_application: Use 'acctest.SkipIfEnvVarNotSet' in a…
065bcdf 
…cceptance tests.
@ewbankkit
r/aws_sns_platform_application: Get GCM acceptance tests working.
f0529b5
@ewbankkit
SNS platform constants not used.
bae4bb7
@ewbankkit
r/aws_sns_topic: Add archive_policy argument and `beginning_archive…
8200c29 
…_time` attribute to support message archiving.
@ewbankkit
r/aws_sns_topic: Test 'archive_policy'.
9bb15b3
@ewbankkit
Add 'verify.SuppressEquivalentJSONWithEmptyDiffs'.
1ed95ea
@ewbankkit
r/aws_sns_topic: Use 'verify.SuppressEquivalentJSONWithEmptyDiffs' fo…
707414f 
…r 'archive_policy'.
@ewbankkit
r/aws_sns_topic: Add replay_policy argument.
ff495d7
@ewbankkit
r/aws_sns_topic: Test 'replay_policy'.
4527630
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/XL Managed by automation to categorize the size of a PR. labels Nov 3, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sns Issues and PRs that pertain to the sns service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) labels Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 3, 2023
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Nov 3, 2023
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 3, 2023
@ewbankkit ewbankkit changed the title [WIP] Migrate sqs resources to AWS SDK for Go v2 [WIP] Migrate sns resources to AWS SDK for Go v2 Nov 3, 2023
@ewbankkit ewbankkit changed the title [WIP] Migrate sns resources to AWS SDK for Go v2 Migrate sns resources to AWS SDK for Go v2 Nov 6, 2023
@ewbankkit ewbankkit merged commit 8d2b69e into main Nov 6, 2023
59 checks passed
@ewbankkit ewbankkit deleted the td-migrate-sns-to-aws-sdk-v2 branch November 6, 2023 12:50
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 6, 2023
github-actions bot pushed a commit that referenced this pull request Nov 6, 2023
Update CHANGELOG.md for #34252
6a44371
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/sns Issues and PRs that pertain to the sns service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v5.25.0
Development

Successfully merging this pull request may close these issues.

SNS FIFO topic message archiving
2 participants
@ewbankkit @justinretzolk